Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] #16079 translation possibility for moreButtonText #16228

Merged
merged 2 commits into from
Jul 7, 2018
Merged

[Forwardport] #16079 translation possibility for moreButtonText #16228

merged 2 commits into from
Jul 7, 2018

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Jun 19, 2018

Description

Added translation possibility for moreButtonText

Fixed Issues (if relevant)

  1. Need information about translating issue (Magento Swatches Js) #16079: Need information about translating issue (Magento Swatches Js)

Manual testing scenarios

You need a Configurable Product with a Swatch Product Attribute in Attribute Set
Swatch attribute have color or image attached to each swatch attribute value
This Parent Product have more than three children configured with the Swatch Attribute
In configuration, you need to have in Catalog > Storefront > Swatches per Product defined to 2
In configuration, you need to have in Catalog > Storefront > Show Swatches in Product List defined to Yes
Swatches have "more" text that can be translated

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2041 has been created to process this Pull Request

@orlangur
Copy link
Contributor

@Karlasa could you please check that fix actually works for 2.3-develop? According to report from QA engineers it is not working.

@Karlasa
Copy link
Contributor Author

Karlasa commented Jun 20, 2018

@orlangur thanks for the info, will check it in beginning of july.

@Karlasa
Copy link
Contributor Author

Karlasa commented Jul 4, 2018

@orlangur Could you send it back to recheck? Same backport ( #16229 ) was merged without issues.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2041 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@Karlasa Karlasa deleted the 2.3-develop-PR-port-16190 branch August 17, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants