Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D… #15943

Merged
merged 2 commits into from
Jun 11, 2018
Merged

[Backport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D… #15943

merged 2 commits into from
Jun 11, 2018

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#15892

Description

Set correct annotation in _toOptionArray - lib\internal\Magento\Framework\Data\SearchResultProcessor.php

Fixed Issues (if relevant)

  1. magento/magento2#<12820>: Wrong annotation in _toOptionArray - lib\internal\Magento\Framework\Data\SearchResultProcessor.php

Manual testing scenarios

  1. Please check request parameter in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal changed the title 2.1 develop pr port 15892 [Backport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D… Jun 8, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jun 11, 2018
@magento-engcom-team magento-engcom-team merged commit 3c58390 into magento:2.1-develop Jun 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 11, 2018
ENGCOM-1937: [Backport] Wrong annotation in _toOptionArray : lib\inte…
0af2aa9 
…rnal\Magento\Framework\D… #15943
@magento-engcom-team
Copy link
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Cleanup Component: Framework/Data Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
4 participants
@gelanivishal @magento-engcom-team @sidolov @sanganinamrata