Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fixed Purchased Order Form button should visible properly #2

Merged
merged 45 commits into from
May 23, 2018
Merged

[Backport] Fixed Purchased Order Form button should visible properly #2

merged 45 commits into from
May 23, 2018

Conversation

gelanivishal
Copy link
Owner

Original Pull Request

magento#15372

Fixed purchase order button issue.

Description

I have fixed place order button issue on selecting purchase order payment method. Please check here
https://www.screencast.com/t/852NjaQC

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. Please add a product in cart and go to checkout page
  2. Select Purchase Order payment method

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

dmytro-ch and others added 30 commits May 18, 2018 08:34
@dmytro-ch
[Backport] Fix typos in variable names
a5e014a
@dmytro-ch
[Backport] Fix typos in PHPDocs and comments
ee90e54
@rogyar
Eliminate usage of "else" statements. Code improvements
b13d09a
@rogyar
Fixed readme minor typo
1b2d726
@VitaliyBoyko
Alignment Array assignment
11c9081
@VitaliyBoyko
Fix typo in securityCheckers array
27e74b9
@VitaliyBoyko
Typo in SSL port number
e74bea1
@VitaliyBoyko
Fix incorrect phpdoc return type
d8fd4ee
@magento-engcom-team
ENGCOM-1590: [Backport] Added hyphenation cutting edge to cutting-edge …
38c44cb 
…magento#15324

 - Merge Pull Request magento#15324 from rogyar/magento2:2.1-readme-typo-cuttingedge
 - Merged commits:
   1. 1b2d726
@VitaliyBoyko
Unused variable removed
2a547a2
@magento-engcom-team
ENGCOM-1594: [Backport] Unused variable removed magento#15385
638f7b0 
 - Merge Pull Request magento#15385 from VitaliyBoyko/magento2:Unused-variable-removed
 - Merged commits:
   1. 2a547a2
@magento-engcom-team
ENGCOM-1595: [Backport] Fix incorrect phpdoc return type magento#15380
221a75c 
 - Merge Pull Request magento#15380 from VitaliyBoyko/magento2:fix-incorrect-phpdoc-return-type
 - Merged commits:
   1. d8fd4ee
@magento-engcom-team
ENGCOM-1596: [Backport] Typo in SSL port number magento#15377
95e5a31 
 - Merge Pull Request magento#15377 from VitaliyBoyko/magento2:Typo-in-SSL-port-number
 - Merged commits:
   1. e74bea1
@magento-engcom-team
ENGCOM-1597: [Backport] Fix typo in securityCheckers array magento#15375
0882ff9 


 - Merge Pull Request magento#15375 from VitaliyBoyko/magento2:Fix-typo-in-securityCheckers-array
 - Merged commits:
   1. 27e74b9
@magento-engcom-team
ENGCOM-1598: [Backport] Alignment Array assignment magento#15363
8b7dbb6 
 - Merge Pull Request magento#15363 from VitaliyBoyko/magento2:Alignement_Array_assignement
 - Merged commits:
   1. 11c9081
@magento-engcom-team
ENGCOM-1600: [Backport] Fix typos in PHPDocs and comments magento#15299
2582a6b 
 - Merge Pull Request magento#15299 from dmytro-ch/magento2:fix/2.1-typos-in-phpdocs-and-comments
 - Merged commits:
   1. ee90e54
@magento-engcom-team
ENGCOM-1601: [Backport] Fix typos in variable names magento#15298
02240c3 
 - Merge Pull Request magento#15298 from dmytro-ch/magento2:fix/2.1-typos-in-variable-names
 - Merged commits:
   1. a5e014a
ENGCOM-1601: [Backport] Fix typos in variable names magento#15298
3f85adf
ENGCOM-1600: [Backport] Fix typos in PHPDocs and comments magento#15299
31ebdf5
ENGCOM-1598: [Backport] Alignment Array assignment magento#15363
344f8cc
ENGCOM-1597: [Backport] Fix typo in securityCheckers array magento#15375
a1087dd
ENGCOM-1596: [Backport] Typo in SSL port number magento#15377
df4f4dc
ENGCOM-1595: [Backport] Fix incorrect phpdoc return type magento#15380
d950ba0
ENGCOM-1594: [Backport] Unused variable removed magento#15385
17a46af
ENGCOM-1590: [Backport] Added hyphenation cutting edge to cutting-edge …
a74e6c4 
…magento#15324
Fix typos in PHPDocs and comments
5e6d1b2
🔃 [EngCom] Public Pull Requests - 2.1-develop
cee0c40 
Accepted Public Pull Requests:
 - magento#15298: [Backport] Fix typos in variable names (by @dmytro-ch)
 - magento#15299: [Backport] Fix typos in PHPDocs and comments (by @dmytro-ch)
 - magento#15363: [Backport] Alignment Array assignment (by @VitaliyBoyko)
 - magento#15375: [Backport] Fix typo in securityCheckers array (by @VitaliyBoyko)
 - magento#15377: [Backport] Typo in SSL port number (by @VitaliyBoyko)
 - magento#15380: [Backport] Fix incorrect phpdoc return type (by @VitaliyBoyko)
 - magento#15385: [Backport] Unused variable removed (by @VitaliyBoyko)
 - magento#15324: [Backport] Added hyphenation cutting edge to cutting-edge (by @rogyar)
@dmytro-ch
[Backport] Remove non-existing argument
3c89d45
@sanganinamrata @dmytro-ch
Fixed typo mistake in function comment
2c31e4d
@sanganinamrata @dmytro-ch
Removed extra added space in function comment and fixed typo mistakes.
32c4a33
magento-engcom-team and others added 3 commits May 22, 2018 18:10
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.1-develop
3085bda 
Accepted Public Pull Requests:
 - magento#15412: [Backport-2.1] Fixed typo in MagentoUi abstract.js (by @VitaliyBoyko)
 - magento#15309: [Backport] Eliminate usage of "else" statements (by @rogyar)
@gelanivishal
Fixed Purchased Order Form button should visible properly
e47349a
@rogyar @gelanivishal
Minor styles nesting fix
c5d2d77
@gelanivishal gelanivishal merged commit 9478138 into 2.1-develop May 23, 2018
gelanivishal pushed a commit that referenced this pull request Jun 1, 2018
@yogeshks
Merge pull request #2 from Yogeshks/2.3-develop-PR-port-15364
c0a6b4a 
[Forwardport] Added language translation for comment tag
gelanivishal pushed a commit that referenced this pull request Jun 8, 2018
@sanganinamrata @gelanivishal
Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
cb0108f 
…ata\SearchResultProcessor.php #2
gelanivishal pushed a commit that referenced this pull request Jun 8, 2018
@sanganinamrata @gelanivishal
Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
3c58390 
…ata\SearchResultProcessor.php #2
gelanivishal pushed a commit that referenced this pull request Jun 8, 2018
@ankurvr
Merge pull request #2 from magento/2.2-develop
56bcffb 
Updated Branch 2.2-develop from Magento 2 upstream
gelanivishal pushed a commit that referenced this pull request Jun 8, 2018
@sanganinamrata
Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D…
27df0e9 
…ata\SearchResultProcessor.php #2
gelanivishal pushed a commit that referenced this pull request Jun 15, 2018
@magento-engcom-team
ENGCOM-1962: [Backport] Resolve Error While Trying To Load Quote Item…
957b835 
… Collection Using Magent… #2 magento#15829

 - Merge Pull Request magento#15829 from neeta-wagento/magento2:2.1-develop-PR-port-11869
 - Merged commits:
   1. c261156
   2. 950e317
gelanivishal pushed a commit that referenced this pull request Jun 15, 2018
@VladimirZaets
ENGCOM-1962: [Backport] Resolve Error While Trying To Load Quote Item…
4d687fe 
… Collection Using Magent… #2 magento#15829
gelanivishal pushed a commit that referenced this pull request Jun 15, 2018
🔃 [EngCom] Public Pull Requests - 2.1-develop
1d129d7 
Accepted Public Pull Requests:
 - magento#15829: [Backport] Resolve Error While Trying To Load Quote Item Collection Using Magent� #2 (by @neeta-wagento)
 - magento#15834: [BackPort] Resolve Knockout non-unique elements id in console error (by @viral-wagento)


Fixed GitHub Issues:
 - magento#8954: Error While Trying To Load Quote Item Collection Using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() (reported by @rendyep) has been fixed in magento#15829 by @neeta-wagento in 2.1-develop branch
   Related commits:
     1. c261156
     2. 950e317

 - magento#15348: Multiple Payment Methods Enabled is giving error in console "Found 3 Elements with non - unique Id" (reported by @neeta-wagento) has been fixed in magento#15834 by @viral-wagento in 2.1-develop branch
   Related commits:
     1. b63d2c5
gelanivishal pushed a commit that referenced this pull request Jun 19, 2018
@magento-engcom-team
ENGCOM-2003: [Forwardport] Removed unnecessary css. #2 magento#15798
18a81a8 
 - Merge Pull Request magento#15798 from chirag-wagento/magento2:2.3-develop-PR-port-15789
 - Merged commits:
   1. cd0a7b4
gelanivishal pushed a commit that referenced this pull request Jun 19, 2018
ENGCOM-2003: [Forwardport] Removed unnecessary css. #2 magento#15798
9ef007d
gelanivishal pushed a commit that referenced this pull request Jun 19, 2018
🔃 [EngCom] Public Pull Requests - 2.3-develop
b8528ae 
Accepted Public Pull Requests:
 - magento#16135: Fix type hints and add undefined property in Webapi [2.3-develop] (by @mhauri)
 - magento#16170: 1163: CreateCreditMemoEntityTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento#16153: 1190: CreateOrderBackendPartOneTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento#16061: Change the favicon file to the newer Magento logo (by @DMMundle)
 - magento#16155: [Forwardport] chore: prefer woff and woff2 (by @DanielRuf)
 - magento#15777: [Forwardport] Fix negative basket total due to shipping tax residue (by @osrecio)
 - magento#15861: [Forwardport] ISSUE-14747 Newsletter subscription confirmation message does not dis� (by @rahul-kachhadiya)
 - magento#16097: [Forwardport] fix: prevent inline-block issue in name form due to space and font-size (by @DanielRuf)
 - magento#15798: [Forwardport] Removed unnecessary css. #2 (by @chirag-wagento)
 - magento#16038: [Forwardport] bugfix checkout page cart icon color (by @chirag-wagento)
 - magento#15759: [Forwardport] 2.3 develop pr port 15566 (by @vgelani)
 - magento#16137: FIX for apparently random API failures while using array types (by @phoenix128)


Fixed GitHub Issues:
 - magento#1163: Problem when change less file in magento. (reported by @zivendesign) has been fixed in magento#16170 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. f53c620

 - magento#1190: installation error in  0.74.0-beta4 (reported by @sivajik34) has been fixed in magento#16153 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 2b8b9d5

 - magento#14747: Newsletter subscription confirmation message does not display after clicking link in email (reported by @tohann) has been fixed in magento#15861 by @rahul-kachhadiya in 2.3-develop branch
   Related commits:
     1. 75516bf

 - magento#16047: inline-block issue in name form (reported by @DanielRuf) has been fixed in magento#16097 by @DanielRuf in 2.3-develop branch
   Related commits:
     1. 204b4ac

 - magento#15565: Getting wrong frontend-controller, when using storecodes in urls (reported by @EliasKotlyar) has been fixed in magento#15759 by @vgelani in 2.3-develop branch
   Related commits:
     1. 61856f5
     2. 4c77dff
gelanivishal pushed a commit that referenced this pull request Jun 30, 2018
@sanganinamrata
Merge pull request #2 from NamrataChangani/2.3-develop-PR-port-15795
1a76cdb 
[Forwardport] Remove double semicolon from the style sheets.
gelanivishal pushed a commit that referenced this pull request Jun 30, 2018
@sanganinamrata
Fixed set template syntax in block file #2
86b9895
gelanivishal pushed a commit that referenced this pull request Jul 14, 2018
@sanganinamrata @gelanivishal
Fixed set template syntax in block file #2
98cc752
gelanivishal pushed a commit that referenced this pull request Jul 20, 2018
@Karlasa
Merge pull request #2 from Karlasa/2.3-develop-PR-port-16190
040e396 
[Forwardport] magento#16079 translation possibility for moreButtonText
gelanivishal pushed a commit that referenced this pull request Aug 6, 2018
@sanganinamrata @gelanivishal
Fixed set template syntax in block file #2
e03cbf3
gelanivishal pushed a commit that referenced this pull request Oct 17, 2018
@BezV8
Merge pull request #2 from magento/2.3-develop
25b40f5 
Sync to magento
gelanivishal pushed a commit that referenced this pull request Oct 27, 2018
@jignesh-baldha @lewisvoncken
Removed unnecessary characters from comments #2
a48bb81
gelanivishal pushed a commit that referenced this pull request Oct 27, 2018
Merge pull request #2 from magento/2.2-develop
8c868c3 
2.2 develop
gelanivishal pushed a commit that referenced this pull request Nov 17, 2018
@ktpl-prakash
Merge pull request #2 from magento/2.3-develop
97d5e9b 
2.3 develop
gelanivishal pushed a commit that referenced this pull request Nov 17, 2018
@swnsma
Merge pull request #2 from magento/2.3-develop
5dc7add 
update
gelanivishal pushed a commit that referenced this pull request Nov 23, 2018
@saphaljha
Merge pull request #2 from magento/2.3-develop
8ea303b 
Update repo
gelanivishal pushed a commit that referenced this pull request Nov 23, 2018
@Karlasa
Merge pull request #2 from Karlasa/Karlasa-clean-up-multiwishlist
69107f4 
Karlasa clean up multiwishlist
gelanivishal pushed a commit that referenced this pull request Dec 13, 2018
@khodu
Merge pull request #2 from magento/2.3-develop
3ba9281 
merge request
gelanivishal pushed a commit that referenced this pull request Dec 13, 2018
@Dharmeshvaja91
Merge pull request #2 from magento/2.3-develop
c0d3480 
Update Magento
gelanivishal pushed a commit that referenced this pull request Dec 13, 2018
@suryakant-krish
Merge pull request #2 from magento/2.3-develop
9143820 
Branch Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gelanivishal @dmytro-ch @rogyar @VitaliyBoyko @magento-engcom-team @sanganinamrata