Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library phpseclib should be upgraded - currently a 2010 version is bundled with M2 #1586

Closed
sebastian-enz opened this issue Jul 29, 2015 · 6 comments
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@sebastian-enz
Copy link
Contributor

See here: https://github.com/magento/magento2/blob/develop/lib/internal/phpseclib/Net/SFTP.php

" $Id: SFTP.php,v 1.21 2010/04/09 02:31:34 terrafrost Exp $ "

Phpseclib is still being actively maintained, even on Github with Composer support. Maybe it should be added via composer to Magento, and not put statically into the "lib" folder?

We are using Net_SFTP in some projects and the 2010 version that is currently bundled with Magento 2 (and Magento 1) is very buggy. They made some huge improvements during the last few years and even added SFTPv2 support.

See: https://github.com/phpseclib/phpseclib

@sebastian-enz sebastian-enz changed the title Library phpseclib should be upgraded - currently a 2010 version is bundled with Magento Library phpseclib should be upgraded - currently a 2010 version is bundled with M2 Jul 29, 2015
@vpelipenko
Copy link
Contributor

@ikk0, thanks for pointing that. It is known issue and it is in progress now. We are going to update this component to the latest version and get it using composer.

@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-37817

@vpelipenko vpelipenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed TECH labels Jul 30, 2015
@orlangur
Copy link
Contributor

This suggestion is also known as #394.

@vpelipenko
Copy link
Contributor

yes, it is the same request.

@vpelipenko
Copy link
Contributor

Phpseclib was removed from source code, added to composer.json and now we work with 0.3.10 version.

@vpelipenko
Copy link
Contributor

Closed as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

3 participants