#10922 add is_active to Magento\Store\Api\Data\StoreInterface

[Zefiryn]

add is_active to Magento\Store\Api\Data\StoreInterface to show it in the rest endpoint

Description

Magento\Store\Api\Data\StoreInterface had no get and set method defined for is_active flag and thus the value did not appear in the V1/store/storeViews endpoint with the store view data

Fixed Issues (if relevant)

1. REST endpoint /V1/store/storeViews is missing is_active value in store data #10922: REST endpoint /V1/store/storeViews is missing is_active value in store data

Manual testing scenarios

1. Perform a rest call to http://store.domain/rest/[store-view-code]/V1/store/storeViews

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[ishakhsuvarov]

Unfortunately, introduction of any new methods to the @api interfaces is not possible due to backwards compatibility policy. This change can potentially break any third-party customization which used this class as SPI (providing their own implementation for existing interface).

Possible workaround would be implementing an extension attribute for this class which would contain the required field. This would not break any existing customization but as a tradeoff would look not as good.

[hervebackstage]

this change was accepted by Anton even though it gave backward compliance issue. I am happy to give a go with the extension attribute but I'd say any developer would see this change as more beneficial as it is now.
--> what I mean is Magento 2 is complex enough to avoid making minor issue to become a big problem?

[ishakhsuvarov]

Please consider updating integration or api-functional for this fix

[vrann]

@Zefiryn now this change can be accepted because it is to the develop branch which will be released as 2.3. This is a MINOR change in API

[hatimeria-artur-jewula]

OK, I will prepare update for tests as requested and add this to this PR.

[vrann]

@hatimeria-artur-jewula just updated api-functional test for this (were failing on or end), so it is good to go

Minor breaking change approved by Anton.