🔃 [Magento Community Engineering] Community Contributions - 2.4-develop

Accepted Community Pull Requests:
 - #29459: [MFTF]Add new ActionGroup  (by @Usik2203)
 - #29669: ChangeQuoteControl minor refactor (by @lbajsarowicz)
 - #29670: Minor refactoring to AccessChangeQuoteControl and it's Unit Tests (by @lbajsarowicz)
 - #29636: [MFTF] AdminMediaGalleryCatalogUiEditCategoryGridPageTest failing randomly  (by @Nazar65)
 - #29630: [MFTF] Add new AdminOrderClickSubmitOrderActionGroup (by @Usik2203)
 - #29564: Refactor Category Link: Replace deprecated interface, clean the code (by @lbajsarowicz)
 - #29518: Refactor not needed before and around plugins (by @ihor-sviziev)
 - #29316: Fix for #29315: \Magento\Config\Model\Config\Source\Email\Tem… (by @willwright)
 - #29339: community-features#252 Create static test for action controllers. (by @swnsma)


Fixed GitHub Issues:
 - #29673: [Issue] ChangeQuoteControl minor refactor (reported by @m2-assistant[bot]) has been fixed in #29669 by @lbajsarowicz in 2.4-develop branch
   Related commits:
     1. 4b0fdfc
     2. 6b01af9
     3. bc5e644

 - #29672: [Issue] Minor refactoring to AccessChangeQuoteControl and it's Unit Tests (reported by @m2-assistant[bot]) has been fixed in #29670 by @lbajsarowicz in 2.4-develop branch
   Related commits:
     1. f0264c9

 - #1764: error when printing order packing slip (reported by @markoshust) has been fixed in #29636 by @Nazar65 in 2.4-develop branch
   Related commits:
     1. d1abc9d
     2. 070749d

 - #29649: [Issue] [MFTF] Add new AdminOrderClickSubmitOrderActionGroup (reported by @m2-assistant[bot]) has been fixed in #29630 by @Usik2203 in 2.4-develop branch
   Related commits:
     1. 674a2f8
     2. de733ae

 - #29679: [Issue] Refactor Category Link: Replace deprecated interface, clean the code (reported by @m2-assistant[bot]) has been fixed in #29564 by @lbajsarowicz in 2.4-develop branch
   Related commits:
     1. 987b162
     2. 77135cf
     3. 8eb39b8

 - #29653: [Issue] Refactor not needed before and around plugins (reported by @m2-assistant[bot]) has been fixed in #29518 by @ihor-sviziev in 2.4-develop branch
   Related commits:
     1. 895c284
     2. b213b79

 - #29315: \Magento\Config\Model\Config\Source\Email\Template::toOptionArray throws error when setPath() is not called first (reported by @willwright) has been fixed in #29316 by @willwright in 2.4-develop branch
   Related commits:
     1. e786d51
     2. e0972bf

app/code/Magento/Catalog/Model/CategoryLink.php

@@ -3,39 +3,41 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Catalog\Model;
 
+use Magento\Catalog\Api\Data\CategoryLinkExtensionInterface;
+use Magento\Catalog\Api\Data\CategoryLinkInterface;
+use Magento\Framework\Model\AbstractExtensibleModel;
+
 /**
  * @codeCoverageIgnore
  */
-class CategoryLink extends \Magento\Framework\Api\AbstractExtensibleObject implements
-    \Magento\Catalog\Api\Data\CategoryLinkInterface
+class CategoryLink extends AbstractExtensibleModel implements CategoryLinkInterface
 {
-    /**#@+
-     * Constants
-     */
-    const KEY_POSITION = 'position';
-    const KEY_CATEGORY_ID = 'category_id';
-    /**#@-*/
+    public const KEY_POSITION = 'position';
+    public const KEY_CATEGORY_ID = 'category_id';
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getPosition()
     {
-        return $this->_get(self::KEY_POSITION);
+        return $this->getData(self::KEY_POSITION);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getCategoryId()
     {
-        return $this->_get(self::KEY_CATEGORY_ID);
+        return $this->getData(self::KEY_CATEGORY_ID);
     }
 
     /**
+     * @inheritDoc
+     *
      * @param int $position
      * @return $this
      */
@@ -56,7 +58,7 @@ public function setCategoryId($categoryId)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
      * @return \Magento\Catalog\Api\Data\CategoryLinkExtensionInterface|null
      */
@@ -66,14 +68,13 @@ public function getExtensionAttributes()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
      * @param \Magento\Catalog\Api\Data\CategoryLinkExtensionInterface $extensionAttributes
      * @return $this
      */
-    public function setExtensionAttributes(
-        \Magento\Catalog\Api\Data\CategoryLinkExtensionInterface $extensionAttributes
-    ) {
+    public function setExtensionAttributes(CategoryLinkExtensionInterface $extensionAttributes)
+    {
         return $this->_setExtensionAttributes($extensionAttributes);
     }
 }

app/code/Magento/Catalog/Model/Indexer/Category/Flat/Plugin/StoreGroup.php

@@ -5,18 +5,13 @@
  */
 namespace Magento\Catalog\Model\Indexer\Category\Flat\Plugin;
 
-use Magento\Framework\Model\ResourceModel\Db\AbstractDb;
-use Magento\Framework\Model\AbstractModel;
-use Magento\Framework\Indexer\IndexerRegistry;
 use Magento\Catalog\Model\Indexer\Category\Flat\State;
+use Magento\Framework\Indexer\IndexerRegistry;
+use Magento\Framework\Model\AbstractModel;
+use Magento\Framework\Model\ResourceModel\Db\AbstractDb;
 
 class StoreGroup
 {
-    /**
-     * @var bool
-     */
-    private $needInvalidating;
-
     /**
      * @var IndexerRegistry
      */
@@ -48,35 +43,21 @@ protected function validate(AbstractModel $group)
         return $group->dataHasChangedFor('root_category_id') && !$group->isObjectNew();
     }
 
-    /**
-     * Check if need invalidate flat category indexer
-     *
-     * @param AbstractDb $subject
-     * @param AbstractModel $group
-     *
-     * @return void
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
-     */
-    public function beforeSave(AbstractDb $subject, AbstractModel $group)
-    {
-        $this->needInvalidating = $this->validate($group);
-    }
-
     /**
      * Invalidate flat category indexer if root category changed for store group
      *
      * @param AbstractDb $subject
-     * @param AbstractDb $objectResource
-     *
+     * @param AbstractDb $result
+     * @param AbstractModel $group
      * @return AbstractDb
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function afterSave(AbstractDb $subject, AbstractDb $objectResource)
+    public function afterSave(AbstractDb $subject, AbstractDb $result, AbstractModel $group)
     {
-        if ($this->needInvalidating && $this->state->isFlatEnabled()) {
+        if ($this->validate($group) && $this->state->isFlatEnabled()) {
             $this->indexerRegistry->get(State::INDEXER_ID)->invalidate();
         }
 
-        return $objectResource;
+        return $result;
     }
 }

app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/StoreGroup.php

@@ -5,19 +5,14 @@
  */
 namespace Magento\Catalog\Model\Indexer\Category\Product\Plugin;
 
-use Magento\Framework\Indexer\IndexerRegistry;
-use Magento\Framework\Model\ResourceModel\Db\AbstractDb;
-use Magento\Framework\Model\AbstractModel;
 use Magento\Catalog\Model\Indexer\Category\Product;
 use Magento\Catalog\Model\Indexer\Category\Product\TableMaintainer;
+use Magento\Framework\Indexer\IndexerRegistry;
+use Magento\Framework\Model\AbstractModel;
+use Magento\Framework\Model\ResourceModel\Db\AbstractDb;
 
 class StoreGroup
 {
-    /**
-     * @var bool
-     */
-    private $needInvalidating;
-
     /**
      * @var IndexerRegistry
      */
@@ -40,36 +35,23 @@ public function __construct(
         $this->tableMaintainer = $tableMaintainer;
     }
 
-    /**
-     * Check if need invalidate flat category indexer
-     *
-     * @param AbstractDb $subject
-     * @param AbstractModel $group
-     *
-     * @return void
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
-     */
-    public function beforeSave(AbstractDb $subject, AbstractModel $group)
-    {
-        $this->needInvalidating = $this->validate($group);
-    }
-
     /**
      * Invalidate flat product
      *
      * @param AbstractDb $subject
-     * @param AbstractDb $objectResource
+     * @param AbstractDb $result
+     * @param AbstractModel $group
      *
      * @return AbstractDb
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function afterSave(AbstractDb $subject, AbstractDb $objectResource)
+    public function afterSave(AbstractDb $subject, AbstractDb $result, AbstractModel $group)
     {
-        if ($this->needInvalidating) {
+        if ($this->validate($group)) {
             $this->indexerRegistry->get(Product::INDEXER_ID)->invalidate();
         }
 
-        return $objectResource;
+        return $result;
     }
 
     /**

app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/StoreView.php

@@ -5,18 +5,18 @@
  */
 namespace Magento\Catalog\Model\Indexer\Category\Product\Plugin;
 
-use Magento\Framework\Model\ResourceModel\Db\AbstractDb;
 use Magento\Framework\Model\AbstractModel;
+use Magento\Framework\Model\ResourceModel\Db\AbstractDb;
 
 class StoreView extends StoreGroup
 {
     /**
      * Validate changes for invalidating indexer
      *
-     * @param \Magento\Framework\Model\AbstractModel $store
+     * @param AbstractModel $store
      * @return bool
      */
-    protected function validate(\Magento\Framework\Model\AbstractModel $store)
+    protected function validate(AbstractModel $store)
     {
         return $store->isObjectNew() || $store->dataHasChangedFor('group_id');
     }
@@ -36,7 +36,7 @@ public function afterSave(AbstractDb $subject, AbstractDb $objectResource, Abstr
             $this->tableMaintainer->createTablesForStore($store->getId());
         }
 
-        return parent::afterSave($subject, $objectResource);
+        return parent::afterSave($subject, $objectResource, $store);
     }
 
     /**

app/code/Magento/Catalog/Model/Indexer/Product/Eav/Plugin/StoreView.php

@@ -3,40 +3,46 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Catalog\Model\Indexer\Product\Eav\Plugin;
 
+use Magento\Catalog\Model\Indexer\Product\Eav\Processor;
+use Magento\Framework\Model\AbstractModel;
+use Magento\Store\Model\ResourceModel\Store;
+
 class StoreView
 {
     /**
      * Product attribute indexer processor
      *
-     * @var \Magento\Catalog\Model\Indexer\Product\Eav\Processor
+     * @var Processor
      */
     protected $_indexerEavProcessor;
 
     /**
-     * @param \Magento\Catalog\Model\Indexer\Product\Eav\Processor $indexerEavProcessor
+     * @param Processor $indexerEavProcessor
      */
-    public function __construct(\Magento\Catalog\Model\Indexer\Product\Eav\Processor $indexerEavProcessor)
+    public function __construct(Processor $indexerEavProcessor)
     {
         $this->_indexerEavProcessor = $indexerEavProcessor;
     }
 
     /**
      * Before save handler
      *
-     * @param \Magento\Store\Model\ResourceModel\Store $subject
-     * @param \Magento\Framework\Model\AbstractModel $object
+     * @param Store $subject
+     * @param Store $result
+     * @param AbstractModel $object
      *
-     * @return void
+     * @return Store
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function beforeSave(
-        \Magento\Store\Model\ResourceModel\Store $subject,
-        \Magento\Framework\Model\AbstractModel $object
-    ) {
-        if ((!$object->getId() || $object->dataHasChangedFor('group_id')) && $object->getIsActive()) {
+    public function afterSave(Store $subject, Store $result, AbstractModel $object)
+    {
+        if (($object->isObjectNew() || $object->dataHasChangedFor('group_id')) && $object->getIsActive()) {
             $this->_indexerEavProcessor->markIndexerAsInvalid();
         }
+
+        return $result;
     }
 }

app/code/Magento/Catalog/Model/Indexer/Product/Flat/Plugin/Store.php

@@ -6,38 +6,43 @@
 
 namespace Magento\Catalog\Model\Indexer\Product\Flat\Plugin;
 
+use Magento\Catalog\Model\Indexer\Product\Flat\Processor;
+use Magento\Framework\Model\AbstractModel;
+use Magento\Store\Model\ResourceModel\Store as StoreResourceModel;
+
 class Store
 {
     /**
      * Product flat indexer processor
      *
-     * @var \Magento\Catalog\Model\Indexer\Product\Flat\Processor
+     * @var Processor
      */
     protected $_productFlatIndexerProcessor;
 
     /**
-     * @param \Magento\Catalog\Model\Indexer\Product\Flat\Processor $productFlatIndexerProcessor
+     * @param Processor $productFlatIndexerProcessor
      */
-    public function __construct(\Magento\Catalog\Model\Indexer\Product\Flat\Processor $productFlatIndexerProcessor)
+    public function __construct(Processor $productFlatIndexerProcessor)
     {
         $this->_productFlatIndexerProcessor = $productFlatIndexerProcessor;
     }
 
     /**
      * Before save handler
      *
-     * @param \Magento\Store\Model\ResourceModel\Store $subject
-     * @param \Magento\Framework\Model\AbstractModel $object
+     * @param StoreResourceModel $subject
+     * @param StoreResourceModel $result
+     * @param AbstractModel $object
      *
-     * @return void
+     * @return StoreResourceModel
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function beforeSave(
-        \Magento\Store\Model\ResourceModel\Store $subject,
-        \Magento\Framework\Model\AbstractModel $object
-    ) {
-        if (!$object->getId() || $object->dataHasChangedFor('group_id')) {
+    public function afterSave(StoreResourceModel $subject, StoreResourceModel $result, AbstractModel $object)
+    {
+        if ($object->isObjectNew() || $object->dataHasChangedFor('group_id')) {
             $this->_productFlatIndexerProcessor->markIndexerAsInvalid();
         }
+
+        return $result;
     }
 }