Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor not needed before and around plugins #29518

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Refactor not needed before and around plugins #29518

merged 2 commits into from
Aug 20, 2020

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Aug 13, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Refactored some parts that using both before and after plugins for save method, also one that uses around.

It's possible to do because of replacing !$object->getId() to $object->isObjectNew() which is true even after saving the model

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Refactor not needed before and around plugins #29653: Refactor not needed before and around plugins

@m2-assistant
Copy link

m2-assistant bot commented Aug 13, 2020

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev changed the title Remove not needed before and around plugins Refactor not needed before and around plugins Aug 13, 2020
@lbajsarowicz lbajsarowicz self-assigned this Aug 13, 2020
@lbajsarowicz
Copy link
Contributor

@ihor-sviziev There are minor issues with the Coding Standard to fix.
A bunch of Unit Tests failed due to the reference to non-existing method.

@ihor-sviziev ihor-sviziev force-pushed the remove-not-needed-before-plugins branch from acd240c to b213b79 Compare August 14, 2020 06:35
@ihor-sviziev
Copy link
Contributor Author

@magento run Unit Tests, Static Tests

@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

lbajsarowicz
lbajsarowicz approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Perfect. Nice to see that you cleaned another part of the world!

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-8013 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Aug 17, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 17, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

The functionality related to indexing has been tested and everything works as previous (expected).

@engcom-Charlie engcom-Charlie self-assigned this Aug 17, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 18, 2020
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 18, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 18, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 18, 2020
Closed
4 tasks
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 19, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 20, 2020
@sidolov
ENGCOM-8013: Refactor not needed before and around plugins #29518
c86883b
@magento-engcom-team magento-engcom-team merged commit 46b09cc into magento:2.4-develop Aug 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 20, 2020

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: CatalogInventory Component: CatalogSearch Component: Theme Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Refactor not needed before and around plugins
6 participants
@ihor-sviziev @lbajsarowicz @magento-engcom-team @engcom-Alfa @sidolov @engcom-Charlie