Handle latest ktlint on windows #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is caused by the fact that KTLint==0.41.0 has altered the way that paths, from CLI, are read and apparently they dropped support for absolute paths as well as for `\` in the Windows path. This commit aims to set a workaround for it
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 318 321 +3
=========================================
+ Hits 318 321 +3
Continue to review full report at Codecov.
|
cortinico
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the #66 we tried to address a new limitation/regression introduced by the latest ktlint version.
Once then the automated PR #67 was created we noticed that windows tests started to fail.
A more complete analysis is present in #67 (comment)
The TL;DR; is
src\file.kt(which is the correct way of describing relative paths on Windows platformsrc\file.ktin the output reporting (which is odd)This PR aims to work-the-issue-around by replacing
\with/in the paths.NOTE: This PR does also make some improvements on the typing of the codebase.
WARNING: ktlint is intentionally not bumped on this PR because I still want to make sure that tests are going to be green with 0.40.0.
Once this will be merged I'll be re-triggering tests of #67 so we can also ensure that they are going to be green (I did already run them locally on a Windows computer)