-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automated PR] Bump KTLint and/or Google Java Formatter #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 318 321 +3
=========================================
+ Hits 318 321 +3
Continue to review full report at Codecov.
|
For some reason tests are failing on windows. Do you happen to know why @macisamuele ? |
I'll be looking into the windows failures. |
@cortinico from a very superficial (possibly still incorrect) analysis I see that windows tests are failing because:
Considering the above findings, I'm going to look more into this hoping to identify what is the root cause of this and hoping that it is testing setup rather than a big regression in ktlint. Edit: After a little debugging I've found out what is happening in here
|
This is caused by the fact that KTLint==0.41.0 has altered the way that paths, from CLI, are read and apparently they dropped support for absolute paths as well as for `\` in the Windows path. This commit aims to set a workaround for it
4dd0729
to
1aaa0a4
Compare
Manually rebased PR on top of #68 . |
Bump KTLint and/or Google Java Formatter
Auto-generated by bump-releases