Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1138

Merged
merged 13 commits into from
Jun 9, 2024
Merged

🌐 New Crowdin updates #1138

merged 13 commits into from
Jun 9, 2024

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Jun 9, 2024

Summary by CodeRabbit

  • New Features

    • Added prompts and descriptions for upgrading to a Pro plan, finalizing event dates, duplicating polls, advanced settings, and retaining polls indefinitely across multiple languages.
  • Localization

    • Updated translations to include new features and descriptions in English, Danish, Basque, Finnish, Hungarian, and Dutch.
    • Added new entries for retaining polls indefinitely in Catalan.

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 4:22pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
landing ⬜️ Ignored (Inspect) Visit Preview Jun 9, 2024 4:22pm

Copy link
Contributor

coderabbitai bot commented Jun 9, 2024

Walkthrough

The recent updates introduce new features and enhancements across multiple language files, focusing on upgrading to a Pro plan, finalizing event dates, duplicating polls, advanced settings, and retaining polls indefinitely. These changes aim to improve user experience by providing more options for managing polls and events, emphasizing clarity and utility.

Changes

File Path Change Summary
apps/web/public/locales/en/app.json Added keys for Pro upgrade prompts, event finalization, poll duplication, advanced settings, and indefinite poll retention.
apps/web/public/locales/da/app.json Introduced entries for account deletion, email verification, Pro upgrade, poll duplication, advanced settings, and indefinite poll retention.
apps/web/public/locales/eu/app.json Added and modified entries related to comments, participants, event management, account deletion, and poll settings.
apps/web/public/locales/fi/app.json Added prompts and descriptions for account actions, Pro upgrade, event finalization, poll duplication, advanced settings, and indefinite poll retention.
apps/web/public/locales/hu/app.json Introduced new prompts and descriptions for Pro upgrade, event finalization, poll duplication, advanced settings, and indefinite poll retention.
apps/web/public/locales/nl/app.json Added entries for Pro upgrade, event finalization, poll duplication, advanced settings, and indefinite poll retention.
apps/web/public/locales/ca/app.json Added entries for keeping polls indefinitely and their descriptions.
apps/landing/public/locales/eu/home.json Updated descriptions and titles to clarify poll and scheduling functionalities, emphasizing ease of use and optimization.

Poem

In the land of polls and plans,
Pro features bloom like flowers in hands,
Duplicate, finalize, settings so grand,
Keep them forever, like castles in sand.
Upgrade your journey, take a stand,
With these changes, your events expand.
🐇✨📊


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 47619bc and b120c0f.

Files selected for processing (4)
  • apps/web/public/locales/en/app.json (1 hunks)
  • apps/web/public/locales/fr/app.json (1 hunks)
  • apps/web/public/locales/hu/app.json (1 hunks)
  • apps/web/public/locales/pl/app.json (1 hunks)
Additional comments not posted (12)
apps/web/public/locales/en/app.json (1)

255-263: All new keys and values in the English locale file are correctly added and follow the intended enhancements for user experience.

apps/web/public/locales/pl/app.json (1)

255-263: All new keys and values in the Polish locale file are correctly added and follow the intended enhancements for user experience.

apps/web/public/locales/fr/app.json (1)

248-253: All new keys and values in the French locale file are correctly added and follow the intended enhancements for user experience.

apps/web/public/locales/hu/app.json (9)

255-255: The key "dangerZoneAccount" is added to provide a warning about irreversible account deletion. Ensure this message is clear and accurately translated across all locales for consistency.


256-256: The key "upgradePromptTitle" is added to prompt users to upgrade to a Pro plan. This is a crucial part of user conversion, so make sure the translation aligns well with marketing tones in other languages.


257-257: The key "upgradeOverlaySubtitle3" is added. It's important that the translation maintains the persuasive tone intended to encourage upgrades. Cross-verify with similar messages in other locales to maintain uniformity.


258-258: The key "finalizeFeatureDescription" is added to explain the feature of finalizing event dates. Check that the description is clear and actionable, and aligns with descriptions in other locales.


259-259: The key "duplicateTitle" is added. This should be a concise and clear label for the duplication feature. Verify consistency with button labels or titles in other sections of the app.


260-260: The key "duplicateFeatureDescription" is added to describe the duplication feature. Ensure the description is detailed enough to convey the feature's functionality clearly.


261-261: The key "advancedSettingsTitle" is added. This should clearly represent the section it refers to. Check for consistency in terminology with other settings-related texts across the app.


262-262: The key "advancedSettingsDescription" is added. It's important that this description accurately lists all the settings covered under this section. Confirm that no setting is omitted and the description matches those in other locales.


263-263: The key "keepPollsIndefinitely" is added to offer users the option to keep polls indefinitely. This should be clearly stated as a benefit, and its implications should be well understood by the users.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b120c0f and 8d2e1ab.

Files selected for processing (5)
  • apps/web/public/locales/da/app.json (1 hunks)
  • apps/web/public/locales/en/app.json (1 hunks)
  • apps/web/public/locales/eu/app.json (1 hunks)
  • apps/web/public/locales/fi/app.json (1 hunks)
  • apps/web/public/locales/hu/app.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • apps/web/public/locales/fi/app.json
Files skipped from review as they are similar to previous changes (2)
  • apps/web/public/locales/en/app.json
  • apps/web/public/locales/hu/app.json
Additional comments not posted (3)
apps/web/public/locales/eu/app.json (2)

235-236: New entries for disabling comments and listing all participants have been added correctly.


240-256: The new entries related to poll management, event hosting, and account deletion are well-formed and align with the feature descriptions provided in the summary.

apps/web/public/locales/da/app.json (1)

248-264: The new entries related to event hosting, account management, and advanced settings have been added correctly and are consistent with the changes in other locale files.

@@ -232,7 +232,26 @@
"or": "Edo",
"autoTimeZone": "Ordu-eremuaren bihurketa automatikoa",
"autoTimeZoneHelp": "Gaitu ezarpen hau gertaeren orduak automatikoki doitzeko parte-hartzaile bakoitzaren tokiko ordu-eremura.",
"commentsDisabled": "Iruzkinak desgaitu dira",
"allParticipants": "Partaide guztiak",
"created": "Sortuta",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key "created" seems to be added without a corresponding value. Please ensure that this is intentional or provide a value if missing.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8d2e1ab and 1076f60.

Files selected for processing (3)
  • apps/landing/public/locales/eu/home.json (1 hunks)
  • apps/web/public/locales/eu/app.json (8 hunks)
  • apps/web/public/locales/nl/app.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/web/public/locales/eu/app.json
Additional comments not posted (14)
apps/landing/public/locales/eu/home.json (4)

23-23: Ensure the updated description aligns with the intended user experience enhancements.

The revised description for availabilityPollDescription enhances clarity and emphasizes ease of scheduling, which aligns well with the application's goals.


30-30: Confirm that the new description matches the feature's functionality.

The new description for findATimeDescription effectively invites users to create polls, facilitating easier scheduling. This should improve user engagement.


33-33: Review the meta description for accuracy and effectiveness.

The updated meta description for freeSchedulingPollMetaDescription succinctly describes the quick and suitable nature of the scheduling polls for various groups, which should help in SEO and user understanding.


35-35: Check if the new description enhances the attractiveness of the feature.

The new description for freeSchedulingPollDescription makes the polls sound appealing and easy to use, which is likely to attract more users to utilize the feature.

apps/web/public/locales/nl/app.json (10)

255-255: Ensure the description for account deletion is clear and warns the user appropriately.

The description under dangerZoneAccount clearly warns users about the irreversible action of deleting their account, which is crucial for avoiding accidental deletions.


256-256: Verify that the upgrade prompt is compelling and clear.

The upgradePromptTitle is straightforward and effectively communicates the action users can take to access more features.


257-257: Check the subtitle for clarity in explaining the benefits of upgrading.

The upgradeOverlaySubtitle3 clearly outlines the benefits of upgrading to a Pro plan, which can help in converting more users to paid plans.


258-258: Confirm that the feature description for finalizing events is accurate.

The finalizeFeatureDescription provides a clear and concise explanation of what the feature does, which is essential for user understanding and correct usage.


259-259: Review the title for the duplicate feature for clarity.

The duplicateTitle is succinct and clearly indicates the functionality, which is to duplicate existing polls.


260-260: Ensure the description for duplicating polls is clear and detailed.

The duplicateFeatureDescription effectively describes how users can reuse data and settings from an existing poll to create a new one, which enhances user experience by simplifying the process.


261-261: Check the title for advanced settings for clarity and relevance.

The advancedSettingsTitle is appropriately labeled, making it clear to users where they can find more complex settings options.


262-262: Review the description for advanced settings to ensure it covers all necessary details.

The advancedSettingsDescription provides a comprehensive list of what the advanced settings entail, helping users understand what they can control.


263-263: Verify the clarity of the feature title for keeping polls indefinitely.

The keepPollsIndefinitely title is clear and directly communicates the feature's purpose, which is to keep polls without an automatic deletion timeline.


264-264: Ensure the description for keeping polls indefinitely is explicit about its functionality.

The keepPollsIndefinitelyDescription clearly explains that inactive polls will not be automatically deleted, which is important for user expectations and data management.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1076f60 and 184d3bd.

Files selected for processing (1)
  • apps/web/public/locales/ca/app.json (1 hunks)
Additional comments not posted (1)
apps/web/public/locales/ca/app.json (1)

220-221: The new keys for indefinite poll retention are clear and align well with the feature's intent.

Ensure that the translations maintain consistency across different languages and that the feature is documented in user guides or help sections.

@lukevella lukevella merged commit 3fea1f8 into main Jun 9, 2024
5 checks passed
@lukevella lukevella deleted the l10n_main branch June 9, 2024 16:38
This was referenced Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant