-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 New Crowdin updates #1138
🌐 New Crowdin updates #1138
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
WalkthroughThe recent updates introduce new features and enhancements across multiple language files, focusing on upgrading to a Pro plan, finalizing event dates, duplicating polls, advanced settings, and retaining polls indefinitely. These changes aim to improve user experience by providing more options for managing polls and events, emphasizing clarity and utility. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- apps/web/public/locales/en/app.json (1 hunks)
- apps/web/public/locales/fr/app.json (1 hunks)
- apps/web/public/locales/hu/app.json (1 hunks)
- apps/web/public/locales/pl/app.json (1 hunks)
Additional comments not posted (12)
apps/web/public/locales/en/app.json (1)
255-263
: All new keys and values in the English locale file are correctly added and follow the intended enhancements for user experience.apps/web/public/locales/pl/app.json (1)
255-263
: All new keys and values in the Polish locale file are correctly added and follow the intended enhancements for user experience.apps/web/public/locales/fr/app.json (1)
248-253
: All new keys and values in the French locale file are correctly added and follow the intended enhancements for user experience.apps/web/public/locales/hu/app.json (9)
255-255
: The key"dangerZoneAccount"
is added to provide a warning about irreversible account deletion. Ensure this message is clear and accurately translated across all locales for consistency.
256-256
: The key"upgradePromptTitle"
is added to prompt users to upgrade to a Pro plan. This is a crucial part of user conversion, so make sure the translation aligns well with marketing tones in other languages.
257-257
: The key"upgradeOverlaySubtitle3"
is added. It's important that the translation maintains the persuasive tone intended to encourage upgrades. Cross-verify with similar messages in other locales to maintain uniformity.
258-258
: The key"finalizeFeatureDescription"
is added to explain the feature of finalizing event dates. Check that the description is clear and actionable, and aligns with descriptions in other locales.
259-259
: The key"duplicateTitle"
is added. This should be a concise and clear label for the duplication feature. Verify consistency with button labels or titles in other sections of the app.
260-260
: The key"duplicateFeatureDescription"
is added to describe the duplication feature. Ensure the description is detailed enough to convey the feature's functionality clearly.
261-261
: The key"advancedSettingsTitle"
is added. This should clearly represent the section it refers to. Check for consistency in terminology with other settings-related texts across the app.
262-262
: The key"advancedSettingsDescription"
is added. It's important that this description accurately lists all the settings covered under this section. Confirm that no setting is omitted and the description matches those in other locales.
263-263
: The key"keepPollsIndefinitely"
is added to offer users the option to keep polls indefinitely. This should be clearly stated as a benefit, and its implications should be well understood by the users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- apps/web/public/locales/da/app.json (1 hunks)
- apps/web/public/locales/en/app.json (1 hunks)
- apps/web/public/locales/eu/app.json (1 hunks)
- apps/web/public/locales/fi/app.json (1 hunks)
- apps/web/public/locales/hu/app.json (1 hunks)
Files skipped from review due to trivial changes (1)
- apps/web/public/locales/fi/app.json
Files skipped from review as they are similar to previous changes (2)
- apps/web/public/locales/en/app.json
- apps/web/public/locales/hu/app.json
Additional comments not posted (3)
apps/web/public/locales/eu/app.json (2)
235-236
: New entries for disabling comments and listing all participants have been added correctly.
240-256
: The new entries related to poll management, event hosting, and account deletion are well-formed and align with the feature descriptions provided in the summary.apps/web/public/locales/da/app.json (1)
248-264
: The new entries related to event hosting, account management, and advanced settings have been added correctly and are consistent with the changes in other locale files.
@@ -232,7 +232,26 @@ | |||
"or": "Edo", | |||
"autoTimeZone": "Ordu-eremuaren bihurketa automatikoa", | |||
"autoTimeZoneHelp": "Gaitu ezarpen hau gertaeren orduak automatikoki doitzeko parte-hartzaile bakoitzaren tokiko ordu-eremura.", | |||
"commentsDisabled": "Iruzkinak desgaitu dira", | |||
"allParticipants": "Partaide guztiak", | |||
"created": "Sortuta", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key "created"
seems to be added without a corresponding value. Please ensure that this is intentional or provide a value if missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- apps/landing/public/locales/eu/home.json (1 hunks)
- apps/web/public/locales/eu/app.json (8 hunks)
- apps/web/public/locales/nl/app.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/web/public/locales/eu/app.json
Additional comments not posted (14)
apps/landing/public/locales/eu/home.json (4)
23-23
: Ensure the updated description aligns with the intended user experience enhancements.The revised description for
availabilityPollDescription
enhances clarity and emphasizes ease of scheduling, which aligns well with the application's goals.
30-30
: Confirm that the new description matches the feature's functionality.The new description for
findATimeDescription
effectively invites users to create polls, facilitating easier scheduling. This should improve user engagement.
33-33
: Review the meta description for accuracy and effectiveness.The updated meta description for
freeSchedulingPollMetaDescription
succinctly describes the quick and suitable nature of the scheduling polls for various groups, which should help in SEO and user understanding.
35-35
: Check if the new description enhances the attractiveness of the feature.The new description for
freeSchedulingPollDescription
makes the polls sound appealing and easy to use, which is likely to attract more users to utilize the feature.apps/web/public/locales/nl/app.json (10)
255-255
: Ensure the description for account deletion is clear and warns the user appropriately.The description under
dangerZoneAccount
clearly warns users about the irreversible action of deleting their account, which is crucial for avoiding accidental deletions.
256-256
: Verify that the upgrade prompt is compelling and clear.The
upgradePromptTitle
is straightforward and effectively communicates the action users can take to access more features.
257-257
: Check the subtitle for clarity in explaining the benefits of upgrading.The
upgradeOverlaySubtitle3
clearly outlines the benefits of upgrading to a Pro plan, which can help in converting more users to paid plans.
258-258
: Confirm that the feature description for finalizing events is accurate.The
finalizeFeatureDescription
provides a clear and concise explanation of what the feature does, which is essential for user understanding and correct usage.
259-259
: Review the title for the duplicate feature for clarity.The
duplicateTitle
is succinct and clearly indicates the functionality, which is to duplicate existing polls.
260-260
: Ensure the description for duplicating polls is clear and detailed.The
duplicateFeatureDescription
effectively describes how users can reuse data and settings from an existing poll to create a new one, which enhances user experience by simplifying the process.
261-261
: Check the title for advanced settings for clarity and relevance.The
advancedSettingsTitle
is appropriately labeled, making it clear to users where they can find more complex settings options.
262-262
: Review the description for advanced settings to ensure it covers all necessary details.The
advancedSettingsDescription
provides a comprehensive list of what the advanced settings entail, helping users understand what they can control.
263-263
: Verify the clarity of the feature title for keeping polls indefinitely.The
keepPollsIndefinitely
title is clear and directly communicates the feature's purpose, which is to keep polls without an automatic deletion timeline.
264-264
: Ensure the description for keeping polls indefinitely is explicit about its functionality.The
keepPollsIndefinitelyDescription
clearly explains that inactive polls will not be automatically deleted, which is important for user expectations and data management.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/public/locales/ca/app.json (1 hunks)
Additional comments not posted (1)
apps/web/public/locales/ca/app.json (1)
220-221
: The new keys for indefinite poll retention are clear and align well with the feature's intent.Ensure that the translations maintain consistency across different languages and that the feature is documented in user guides or help sections.
Summary by CodeRabbit
New Features
Localization