-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generators to add/remove #51
Comments
Since nouns are already in there adding adjectives and verbs would also be nice: Also fun, but probably less useful, would be to have this list of programming languages: |
@jorinvo I like that too. So I'll add them to the list. I'm assuming you're fine with what I'd like to remove? If so I'll go ahead and take care of this |
yes, sounds good :) |
@jorinvo I couldn't add verbs and programming languages with the import code we have as the JSON doesn't follow the convention of the rest of the repository (maybe we should open an issue on the project and discuss that. Having a convention there helps a lot with automation) but since they're addition I think we can add them even when 1.0.0 is already out. The changes are in #52 |
So far we never had a conversation about which generators make sense for version 1.0.0 and while working on #50 I realised it's a good time to change that. Right now most of what we did is either inherited from phony or imported (as an example) from corpora. In practise, we have the following generators:
I would like to remove the following:
and add:
At first, I thought we should remove more (and commented in #44 about that) but looking at the data we can import from corpora I realise it's probably nicer if people can choose what to generate even more granularly.
The text was updated successfully, but these errors were encountered: