Update current defaults for WEP pipelines #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeyers314
approved these changes
Nov 29, 2024
| @@ -8,7 +8,7 @@ tasks: | |||
| calcZernikesTask: | |||
| class: lsst.ts.wep.task.calcZernikesTask.CalcZernikesTask | |||
| config: | |||
| estimateZernikes.nollIndices: [4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22] | |||
| estimateZernikes.nollIndices: [4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 18, 19, 20, 21, 22, 27, 28] | |||
There was a problem hiding this comment.
Do we trust 18, 19 more for TIE than for danish?
There was a problem hiding this comment.
Not necessarily, but my testing found that it was sometimes needed for TIE convergence. We're currently running with a max 50 iterations though, so we could probably remove them if you like
Updated TIE defaults Update versionHistory.rst
jfcrenshaw
force-pushed
the
update-wep-pipeline-defaults
branch
from
f3063ea to
f883399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes sparsity, binning in Danish