Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Document the manual assessment of programming exercises #8968

Merged
merged 10 commits into from
Jul 5, 2024

Conversation

pzdr7
Copy link
Contributor

@pzdr7 pzdr7 commented Jul 4, 2024

Checklist

General

Motivation and Context

Manual assessment in the code editor was not documented. Recent changes in #8921 modified the user interface.

Description

Steps for Testing

Added a note: https://artemis-platform--8968.org.readthedocs.build/en/8968/user/assessment.html#manual-assessment

Added a section: https://artemis-platform--8968.org.readthedocs.build/en/8968/user/exercises/programming.html#manual-assessment

Review Progress

  • Code Review 1
  • Code Review 2

Screenshots

Refer to the documentation

Summary by CodeRabbit

  • Documentation
    • Restructured the explanation of manual assessment in Artemis.
    • Enhanced documentation for file uploads with improved structure and navigation elements.
    • Added a new section for manual assessment in the online editor for programming exercises, detailing features like file browsing, build output display, read-only code editor, feedback addition, and assessment finalization.
    • Introduced reference links for better navigation in various exercise documents (modeling, textual).

@pzdr7 pzdr7 self-assigned this Jul 4, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 5, 2024
@pzdr7 pzdr7 removed the stacked-pr label Jul 5, 2024
@pzdr7 pzdr7 changed the base branch from chore/programming-exercises/improve-manual-assessment to develop July 5, 2024 08:48
@pzdr7 pzdr7 dismissed coderabbitai[bot]’s stale review July 5, 2024 08:48

The base branch was changed.

@pzdr7 pzdr7 force-pushed the chore/development/docs-programming-manual-assessment branch from d2ccfa2 to 891813a Compare July 5, 2024 08:56
@pzdr7 pzdr7 marked this pull request as ready for review July 5, 2024 08:58
@pzdr7 pzdr7 requested a review from a team as a code owner July 5, 2024 08:58
Copy link

coderabbitai bot commented Jul 5, 2024

Walkthrough

The recent changes primarily enhance the documentation for various exercise types within Artemis. These enhancements focus on improving manual assessment explanations and adding reference links for better navigation. Importantly, a new section detailing the manual assessment process in the online editor for programming exercises has been introduced. This offers a comprehensive guide on providing feedback, adding comments, and finalizing assessments using the online editor interface.

Changes

Files Change Summary
docs/user/assessment.rst Restructured the explanation of manual assessment, emphasizing general concepts and specific exercise types.
docs/user/exercises/file-upload.rst Added a reference marker file-upload at the beginning of the document to improve navigation.
docs/user/exercises/modeling.rst Added a reference link _modeling to introduce a new section or anchor point for navigation.
docs/user/exercises/textual.rst Added a reference link _textual at the beginning of the document to enhance navigational structure.
docs/user/exercises/programming.rst Introduced a new section on manual assessment in the online editor, detailing features and processes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant OnlineEditor
    participant BuildSystem
    participant FeedbackSystem
    
    User->>OnlineEditor: Open Programming Exercise
    OnlineEditor-->>User: Display Files, Build Output
    
    User->>OnlineEditor: Provide Feedback/Comments
    OnlineEditor->>BuildSystem: Display Build Output
    BuildSystem-->>OnlineEditor: Return Build Output
    
    User->>OnlineEditor: Add Feedback, Comments
    
    OnlineEditor->>FeedbackSystem: Submit Feedback and Comments
    FeedbackSystem-->>OnlineEditor: Confirmation of Submission
    OnlineEditor-->>User: Feedback Submitted Successfully
Loading

Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between aa8a382 and 9187371.

Files selected for processing (1)
  • docs/user/exercises/programming.rst (1 hunks)
Additional comments not posted (7)
docs/user/exercises/programming.rst (7)

143-145: LGTM!

The description of the saving process and finalizing the assessment is clear and provides sufficient context for the reader.


146-162: LGTM!

The image references for various buttons used in the online editor are correct and provide sufficient context for the reader.


161-162: LGTM!

The content under "Repository Access" is clear and provides sufficient context for the reader.


119-119: Clarify the build output description.

The sentence "The build output shows the output of the build process, if any." can be expanded for clarity.

- The build output shows the output of the build process, if any.
+ The build output shows the output of the build process, if any. This is useful in case of build errors.

Likely invalid or redundant comment.


104-108: Clarify the alternative methods for manual assessment.

The sentence "Alternatively, you can use the online editor to assess the students' submissions." can be expanded for clarity.

- Alternatively, you can use the online editor to assess the students' submissions.
+ Alternatively, you can use the online editor within Artemis to assess the students' submissions directly in the browser.

Likely invalid or redundant comment.


132-132: Clarify the process for entering feedback comments and scores.

The sentence "After clicking the button, you can enter a feedback comment and a score for the selected line." can be expanded for clarity.

- After clicking the button, you can enter a feedback comment and a score for the selected line.
+ After clicking the |add-feedback-button| button, you can enter a feedback comment and assign a score for the selected line.

Likely invalid or redundant comment.


116-116: Ensure the general feedback button is clearly described.

The sentence "For manual assessment, the online editor provides the following features tailored to the assessment process:" can be expanded for clarity.

- For manual assessment, the online editor provides the following features tailored to the assessment process:
+ For manual assessment, the online editor provides the following features tailored to the assessment process, which include:

Likely invalid or redundant comment.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pzdr7 pzdr7 changed the title Development: Document manual assessment for programming exercises Development: Document the manual assessment of programming exercises Jul 5, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 5, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 5, 2024
JohannesStoehr
JohannesStoehr previously approved these changes Jul 5, 2024
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

Jan-Thurner
Jan-Thurner previously approved these changes Jul 5, 2024
Copy link
Contributor

@Jan-Thurner Jan-Thurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Documentation LGTM

florian-glombik
florian-glombik previously approved these changes Jul 5, 2024
Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Found one misplaced comma, and left a few comments that are not blocking are merge from my point of view

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 5, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

@pzdr7 pzdr7 added this to the 7.4.1 milestone Jul 5, 2024
Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes - re-approve

Copy link
Contributor

@edkaya edkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in doc look good to me

@krusche krusche merged commit 19a4ee6 into develop Jul 5, 2024
16 of 18 checks passed
@krusche krusche deleted the chore/development/docs-programming-manual-assessment branch July 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants