Team exercises: Fix missing open editor button when individual deadline set

[EneaGore]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I strictly followed the client coding and design guidelines.
• I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Fixes issue 8610

Description

When booleans are set whether a button should be shown or not individual deadline is not considered. Now it is included in all exercises.

Steps for Testing

Prerequisites:

• 1 Instructor
• 2 Students
• 1 Exercise of each type

DONT test on TS2 or TS3

1. Log in to Artemis
2. Create Team and individual Exercises
3. 1 Student/Team participates before deadline, 1 after deadline
4. Change individual deadline
5. Confirm that button to submit is available and submit button also looks and works correctly.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Screenshots

Before:


After:

[coderabbitai]

Walkthrough

The changes primarily enhance how various components handle dates related to participation and deadlines in an educational application. Specifically, they introduce more granular checks using individualDueDate alongside general dueDate conditions, ensuring more precise and personalized deadline management for users.

Changes

File Path	Change Summary
src/main/webapp/app/exercises/modeling/participate/modeling-submission.component.ts	Added a condition to check if participation.initializationDate is after participation.individualDueDate.
src/main/webapp/app/exercises/text/participate/text-editor.component.ts	Enhanced the isActive calculation with a new check for dayjs().isBefore(this.participation?.individualDueDate).
src/main/webapp/app/overview/exercise-details/exercise-details-student-actions.component.ts	Updated the beforeDueDate calculation to also check if the current date is before individualDueDate.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant System
    participant DateConditionChecker

    User-->>System: Initiates action (e.g., submission, editing)
    System->>DateConditionChecker: Check due dates (general and individual)
    DateConditionChecker-->>System: Return results of due date checks
    System-->>User: Proceed based on due date checks

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[SimonEntholzer]

Code fix makes sense 👍