Development: Add multi node e2e tests with playwright

[BBesrour]

Checklist

General

• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

Production runs in a multi-node setup. Therefore, tests should run on the same setup.
bamboo server tests

Steps for Testing

Artemis E2E Playwright Tests (MySQL, Local, Multi-Node) need to pass on Bamboo. CI has already been adjusted to use the multi-node config.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

[coderabbitai]

Walkthrough

The recent changes focus on enhancing multi-node configuration support for end-to-end (E2E) testing environments using Playwright and Cypress. This includes updates to Docker commands in the cleanup and execution scripts to ensure proper setup and teardown of multi-node environments. Additionally, minor adjustments were made to the PlaywrightUserManagement class to correctly concatenate username and password templates with the USER_ID_SELECTOR.

Changes

Files	Change Summary
.ci/E2E-tests/cleanup.sh	Added commands to bring down multi-node E2E test environments using Playwright and Cypress in Docker.
.ci/E2E-tests/execute.sh	Added support for multi-node configuration in Playwright and Cypress. Updated Docker image handling and error messages.
src/test/playwright/support/users.ts	Modified getUsernameTemplate() and getPasswordTemplate() methods to correctly concatenate strings with USER_ID_SELECTOR.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Out of diff range and nitpick comments (1)

.ci/E2E-tests/cleanup.sh (1)

Line range hint 4-4: Separate declaration and assignment, and quote the variable to prevent word splitting.

- export HOST_HOSTNAME=$(hostname)
+ HOST_HOSTNAME=$(hostname)
+ export HOST_HOSTNAME="$HOST_HOSTNAME"

[SimonEntholzer]

Multinode playwright and cypress ymls look good

[florian-glombik]

Most of the issues I addressed are style issues, depending on the urgency of the PR we might want to address them in a follow up PR 😅

[coderabbitai]

Actionable comments posted: 5

Out of diff range and nitpick comments (2)

.ci/E2E-tests/execute.sh (2)

Line range hint 46-47: Double quote to prevent globbing and word splitting.

- echo $COMPOSE_FILE
+ echo "$COMPOSE_FILE"

---

Line range hint 47-47: Double quote to prevent globbing and word splitting.

- mv ./*.war build/libs/
+ mv "./*.war" "build/libs/"

[florian-glombik]

Thank you for addressing the comments and having a look into the anchors!

I think with adding another anchor for the depend_on section the yml will be even easier to read, as the differences are easier to sport then

[florian-glombik]

The code looks good to me, thanks for addressing the anchor suggestions! :)

[julian-christl]

I don't know much about Dockerconfigs, so I couldn't really review that section, but I didn't find anything directly myself.

One comment, optional.