Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Java programming exercise templates based on new artemis-java-test-sandbox version #2382

Merged
merged 25 commits into from
Nov 17, 2020
Merged

Simplify Java programming exercise templates based on new artemis-java-test-sandbox version #2382

merged 25 commits into from
Nov 17, 2020

Conversation

krusche
Copy link
Member

@krusche krusche commented Nov 11, 2020 •
edited
Loading

Checklist

Motivation and Context

Simplify the template, move test classes (which do not change between projects) into artemis-java-test-sandbox and use them based on the downloaded maven dependency

Steps for Testing

  1. Create multiple programming exercises. Create in total 6 exercises:
  • Java/ Non-Sequential/ Maven project type
  • Java/ Non-Sequential/ Eclipse project type
  • Java/ Sequential/ Maven project type
  • Java/ Sequential/ Eclipse project type
  • Kotlin/ Non-Sequential
  • Kotlin/ Sequential
  1. Try out that the tests for template and solution are still working properly
  2. Participate in the exercises
  3. Make a submission and check that everything still works

Related artemis-java-test-sandbox PR: ls1intum/Ares#62

@krusche krusche added this to the 4.7.5 milestone Nov 11, 2020
@krusche krusche self-assigned this Nov 11, 2020
@krusche krusche requested review from sleiss, MaisiKoleni, fde312 and kloessst and removed request for sleiss and MaisiKoleni November 11, 2020 15:56
@krusche krusche mentioned this pull request Nov 11, 2020
Merged
2 tasks
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Nov 11, 2020
@kloessst kloessst self-assigned this Nov 11, 2020
@krusche krusche modified the milestones: 4.7.5, 4.7.4 Nov 17, 2020
@derLalla derLalla self-assigned this Nov 17, 2020
MaisiKoleni
MaisiKoleni suggested changes Nov 17, 2020
View reviewed changes
src/main/resources/templates/java/maven/test/projectTemplate/pom.xml Outdated Show resolved Hide resolved
src/main/resources/templates/java/maven/test/projectTemplate/pom.xml Outdated Show resolved Hide resolved
src/main/resources/templates/java/test/projectTemplate/pom.xml Outdated Show resolved Hide resolved
src/main/resources/templates/java/test/projectTemplate/pom.xml Outdated Show resolved Hide resolved
src/main/resources/templates/java/test/testFiles/structural/AttributeTest.java Show resolved Hide resolved
src/main/resources/templates/java/test/testFiles/structural/AttributeTest.java Outdated Show resolved Hide resolved
src/main/resources/templates/kotlin/test/projectTemplate/pom.xml Outdated Show resolved Hide resolved
src/main/resources/templates/kotlin/test/projectTemplate/pom.xml Outdated Show resolved Hide resolved
src/main/resources/templates/kotlin/test/testFiles/structural/AttributeTest.java Show resolved Hide resolved
kloessst and others added 2 commits November 17, 2020 18:42
@kloessst kloessst requested a review from MaisiKoleni November 17, 2020 18:04
@krusche krusche marked this pull request as ready for review November 17, 2020 19:26
@krusche krusche requested review from jpbernius and a team as code owners November 17, 2020 19:26
kloessst
kloessst approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@kloessst kloessst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the programming exercises described in the testing steps. All template participations have 0% and all solution participations have 100%. Works fine for me.

@krusche krusche merged commit 9064344 into develop Nov 17, 2020
@krusche krusche deleted the feature/programming-exercise/update-java-template branch November 17, 2020 20:25
@MaisiKoleni MaisiKoleni mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kloessst kloessst kloessst approved these changes

@sleiss sleiss Awaiting requested review from sleiss

@fde312 fde312 Awaiting requested review from fde312

@MaisiKoleni MaisiKoleni Awaiting requested review from MaisiKoleni

@jpbernius jpbernius Awaiting requested review from jpbernius

Assignees

@krusche krusche

@kloessst kloessst

@derLalla derLalla

Labels
component:Programming ready for review server Pull requests that update Java code. (Added Automatically!)
Projects
None yet
Milestone
4.7.4
Development

Successfully merging this pull request may close these issues.
4 participants
@krusche @MaisiKoleni @kloessst @derLalla