Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Update node and npm version #10387

Merged
merged 2 commits into from
Feb 22, 2025
Merged

Conversation

krusche
Copy link
Member

@krusche krusche commented Feb 22, 2025

We want to keep node and npm up to date.

  • All relevant checks pass

Summary by CodeRabbit

  • Documentation
    • Updated version specifications for Node.js and npm in the setup documentation.
    • Adjusted reference documentation to reflect the latest Node.js memory configuration specifications.
  • Chores
    • Upgraded Node.js to version 22.14.0 and npm to version 11.1.0.
    • Enforced new minimum engine requirements for Node.js (>=22.14.0) and npm (>=11.1.0).

@krusche krusche requested a review from a team as a code owner February 22, 2025 20:56
@krusche krusche added this to the 7.10.3 milestone Feb 22, 2025
Copy link

coderabbitai bot commented Feb 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR updates Node.js and npm version references across documentation and configuration files. The client setup documentation now links to the correct Node.js memory limit documentation for version 22.x instead of 16.x. Additionally, both the Gradle and package configuration files have been updated with newer Node.js and npm versions to ensure consistency in environment setup, without modifying any functional or public API declarations.

Changes

File(s) Change Summary
docs/dev/setup/client.rst Updated the URL in the hint section to reference the Node.js memory limit option (--max-old-space-size) for Node.js v22.x (previously v16.x).
gradle.properties, package.json Upgraded Node.js and npm versions: In gradle.properties, node_version bumped from 22.12.0 to 22.14.0 and npm_version from 10.9.0 to 11.1.0; in package.json, updated the engines section to require Node.js >=22.14.0 and added a minimum npm version requirement of >=11.1.0.
docs/dev/setup.rst Updated Node.js version requirement from Node.js (>=22.10.0 < 23) to node (>=22.14.0 < 23) and npm requirement from Npm (>=10.8.0) to npm (>=11.1.0), ensuring consistent casing.

Possibly related PRs

  • Development: Update node to 22 #9642: The changes in the main PR, which update the Node.js version references in documentation and configuration files, are related to the retrieved PR that also updates the Node.js version requirement in similar files.
  • Development: Update server dependencies #9092: The changes in the main PR, which update Node.js version references in documentation and configuration files, are related to the updates in the gradle.properties file of the retrieved PR that also involve Node.js version changes.
  • Development: Update client dependencies #9093: The changes in the main PR, which update Node.js version references in documentation and configuration files, are related to the updates in the package.json file of the retrieved PR, as both involve modifications to Node.js version specifications.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 703ce00 and d2a7393.

📒 Files selected for processing (1)
  • docs/dev/setup.rst (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 22, 2025
@krusche krusche merged commit 8b3c4ed into develop Feb 22, 2025
14 of 19 checks passed
@krusche krusche deleted the chore/update-node-npm branch February 22, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

1 participant