Skip to content

Commit

Permalink
implement feedback from Aniruddh and Codacy
Browse files Browse the repository at this point in the history
  • Loading branch information
rabeatwork committed Feb 18, 2025
1 parent 040ff65 commit 6bd8041
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,11 @@ jhi-posting-thread {

.channel-content {
height: calc(100vh - 1rem - var(--header-height) - var(--message-input-height-dev) - var(--channel-header-height));

@include media-breakpoint-down(md) {

Check warning on line 120 in src/main/webapp/app/overview/course-conversations/layout/conversation-messages/conversation-messages.component.scss

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/main/webapp/app/overview/course-conversations/layout/conversation-messages/conversation-messages.component.scss#L120

Unexpected unknown at-rule "@include" (at-rule-no-unknown)
height: calc(100vh - var(--header-height) - var(--message-input-height-dev) - var(--channel-header-height));
}

display: flex;
flex-direction: column;
justify-content: space-between;
Expand Down
6 changes: 3 additions & 3 deletions src/main/webapp/i18n/en/conversation.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"searchLabel": "Search messages",
"clearSearch": "Clear search",
"searchBarPlaceholder": "Search within current channel",
"searchResultsMultiple": "{{ count }} Results",
"searchResultsSingle": "1 Result",
"searchResultsNone": "No Results"
"searchResultsMultiple": "{{ count }} results",
"searchResultsSingle": "1 result",
"searchResultsNone": "No results"
},
"threadSideBar": {
"label": "Thread",
Expand Down

0 comments on commit 6bd8041

Please sign in to comment.