Add Randomization Logic to Generated Memories #8170
Merged
+55
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lowering `hw.module.generated`, copy any emit dialect fragments that were on the original operation. This allows for fragments created earlier to be propagated along without having to teach `HWMemSimImpl` about them. Signed-off-by: Schuyler Eldridge <[email protected]>
When generating modules as part of the SeqToSV conversion, put appropriate memory generation fragments onto the created `hw.module.generated`. No longer put memory randomization fragments onto the original module. Fixes #8164. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/issue-8164
branch
from
9cb6175 to
d47a9d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lowering
hw.module.generated, copy any emit dialect fragments thatwere on the original operation. This allows for fragments created
earlier to be propagated along without having to teach
HWMemSimImplabout them.
When generating modules as part of the SeqToSV conversion, put appropriate
memory generation fragments onto the created
hw.module.generated. Nolonger put memory randomization fragments onto the original module.
Fixes #8164.