Make alignment when free space is negative configurable #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
changed the title
Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
negative-space-alignment
branch
from
fb70aeb to
5c855df
Compare
tomcur
reviewed
Jan 17, 2025
Signed-off-by: Nico Burns <[email protected]>
nicoburns
changed the title
Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
negative-space-alignment
branch
from
c762f49 to
4ec40e5
Compare
tomcur
approved these changes
Jan 21, 2025
| layout.align( | ||
| max_advance, | ||
| Alignment::Start, | ||
| false, /* align_when_overflowing */ |
There was a problem hiding this comment.
If align gains more options in the future, a boolean may be a bit confusing, especially if people don't document as you've done here. Maybe an AlignmentOptions struct could be introduced?
There was a problem hiding this comment.
Agree, but don't have time to work on this now. In the interest of getting this landed for Parley 0.3 I'm going to merge this as-is. And have created an issue for the options struct (#247)
Signed-off-by: Nico Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, but probably fixes #240