Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boolean option in Layout::align with AlignmentOptions Struct #247

Closed
nicoburns opened this issue Jan 22, 2025 · 0 comments · Fixed by #278
Closed

Replace boolean option in Layout::align with AlignmentOptions Struct #247

nicoburns opened this issue Jan 22, 2025 · 0 comments · Fixed by #278
Labels
enhancement New feature or request
Milestone
0.3 Release

Comments

@nicoburns
Copy link
Contributor

See #241 (comment)
@nicoburns nicoburns added the enhancement New feature or request label Jan 22, 2025
@nicoburns nicoburns mentioned this issue Jan 22, 2025
Merged
@tomcur tomcur added this to the 0.3 Release milestone Feb 7, 2025
@DJMcNab DJMcNab mentioned this issue Feb 17, 2025
Merged
@nicoburns nicoburns mentioned this issue Feb 17, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 18, 2025
@nicoburns
Replace boolean parameter to Layout::align with AlignmentOptions …
77d1bba 
…struct (#278)

- Fixes #247
- Builds on top of #271 as
otherwise these would conflict

A small but nice improvement to the public API.

Signed-off-by: Nico Burns <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3 Release
Development

Successfully merging a pull request may close this issue.

Replace boolean parameter to Layout::align with AlignmentOptions struct nicoburns/parley
2 participants
@nicoburns @tomcur