Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channeldb: keep remote commit diff in memory #3952

Closed
wants to merge 1 commit into from
Closed

channeldb: keep remote commit diff in memory #3952

wants to merge 1 commit into from

Conversation

joostjager
Copy link
Contributor

This change is preparation for anchor output resolution. By not querying the remote commit diff on demand from the database, it will be easier write unit tests for the channel arbitrator.

Additionally, this change will improve performance by eliminating a database lookup for every commitment signed.

@joostjager
channeldb: keep remote commit diff in memory
b9884a6 
This change is preparation for anchor output resolution. By not querying
the remote commit diff on demand from the database, it will be easier
write unit tests for the channel arbitrator.

Additionally, this change will improve performance by eliminating a
database lookup for every commitment signed.
@joostjager joostjager mentioned this pull request Jan 23, 2020
Closed
@joostjager joostjager marked this pull request as ready for review January 23, 2020 16:32
@joostjager joostjager requested a review from Roasbeef as a code owner January 23, 2020 16:32
@joostjager joostjager requested review from halseth and removed request for Roasbeef January 23, 2020 16:33
@joostjager joostjager added channels commitments Commitment transactions containing the state of the channel database Related to the database/storage of LND labels Jan 23, 2020
@Roasbeef Roasbeef added this to the 0.10.0 milestone Jan 23, 2020
@Roasbeef Roasbeef requested a review from carlaKC January 24, 2020 00:52
@joostjager
Copy link
Contributor Author

I am probably going with a different approach for which this change isn't needed.

@Roasbeef Roasbeef closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
channels commitments Commitment transactions containing the state of the channel database Related to the database/storage of LND
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joostjager @Roasbeef