[anchors] anchors resolutions #3920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
joostjager
reviewed
Jan 16, 2020
| // The anchor chennel type MUST be tweakless. | ||
| if chanState.ChanType.HasAnchors() && !chanState.ChanType.IsTweakless() { | ||
| panic("invalid channel type combination") | ||
| } |
halseth
force-pushed
the
pluggable-anchors-resolutions
branch
from
309bd49 to
d42b40a
Compare
It takes into account the necessary variables and will prepare us for doing commitment type dependent script generation later.
This fixes an error case that wouldn't have been caught, since vm.Execute applies more rules than the individual steps (most notably the clean stack rule). Instead we execute the engine as normal, and only step through if we decide that the outcome is unexpected.
With this commitment type, we'll add extra anchor outputs to the commitment transaction if the anchor channel type is active.
… type Based on the channel type, the commitment weight will be calculated.
If we are the initiator, we check that our starting balance after subtracting fees are not less than two times the default dust limit. This commit adds a similar check for the non-initiator case, checking that the remote party has a starting balance of reasonable size.
Preparing for funding flow to be able to set anchor type if agreed upon.
…from confirmed bucket Co-authored-by: Joost Jager <[email protected]>
halseth
force-pushed
the
pluggable-anchors-resolutions
branch
from
d42b40a to
8a66a32
Compare
joostjager
reviewed
Jan 23, 2020
| } | ||
|
|
||
| // Fetch the two latest commitments. | ||
| localCommit, remoteCommit, err := chanState.LatestCommitmentsFrom( |
There was a problem hiding this comment.
Aren't these two already present in chanState.LocalCommitment and chanState.RemoteCommitment?
joostjager
reviewed
Jan 23, 2020
|
|
||
| // RemoteCommitChainTip returns the "tip" of the current remote commitment | ||
| // chain. The confirmed bool indicates which bucket to retrieve the data from. | ||
| func (c *OpenChannel) RemoteCommitChainTipFrom(confirmed bool) (*CommitDiff, |
There was a problem hiding this comment.
If we do #3952, the ...From() isn't needed.
|
Moved to more conservative way of dealing with the anchor resolution, which simplifies the changes introduced in this pr. Closing this and made the change part of #3758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #3821