Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #845 - Remove resizer everytime the cursor gets out of the pillar. Keeping the resizer there without any reason creates a black hole where the CKEditor's mousemove event is never triggered #893

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

julien
Copy link
Contributor

@julien julien commented Oct 22, 2018

No description provided.

…. Keeping the resizer there without any reason creates a black hole where the CKEditor's mousemove event is never triggered
@julien
Copy link
Contributor Author

julien commented Oct 23, 2018

@rodrigopaulino the CI is failing but it doesn't seem related to the changes.

The error messages I'm seeing look like this

23 10 2018 07:24:48.187:ERROR [launcher.sauce]: Can not start microsoftedge 14 (Windows 10)
  [init({"version":"14","platform":"Windows 10","tags":[],"name":"AlloyEditor tests","tunnel-identifier":"karma1540279455","record-video":false,"record-screenshots":false,"device-orientation":null,"disable-popup-handler":true,"build":"1131","public":null,"customData":{},"base":"SauceLabs","browserName":"microsoftedge"})] The environment you requested was unavailable.
  {"status": 13, "sessionId": "6f8a2d6a65b84be38814d1b5704b2b2d", "value": {"message": "Sauce could not start your job. For more information on what happened, please visit https://saucelabs.com/jobs/6f8a2d6a65b84be38814d1b5704b2b2d"}}
23 10 2018 07:24:48.187:ERROR [launcher]: microsoftedge 14 (Windows 10) on SauceLabs failed 2 times (failure). Giving up.

So I'm guessing it's a configuration problem.
I'll ask @jbalsas and will keep you updated soon

Thanks.

@julien
Copy link
Contributor Author

julien commented Oct 23, 2018

@rodrigopaulino the CI ran the tests successfully, so I'm merging this.
I'll prepare the release and update in portal when ready.
Thanks!

@julien julien merged commit 91238c5 into master Oct 23, 2018
@rodrigopaulino
Copy link
Contributor

Thank you, @julien

@julien julien deleted the pr-892 branch January 24, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants