Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #845 - Remove resizer everytime the cursor gets out of the pillar… #892

Closed
wants to merge 1 commit into from

Conversation

rodrigopaulino
Copy link
Contributor

@rodrigopaulino rodrigopaulino commented Oct 18, 2018

… pillar. Keeping the resizer there without any reason creates a black hole where the CKEditor's mousemove event is never triggered
@jbalsas
Copy link
Contributor

jbalsas commented Oct 22, 2018

@julien, could you take a look at this one?

4 similar comments
@jbalsas
Copy link
Contributor

jbalsas commented Oct 22, 2018

@julien, could you take a look at this one?

@jbalsas
Copy link
Contributor

jbalsas commented Oct 22, 2018

@julien, could you take a look at this one?

@jbalsas
Copy link
Contributor

jbalsas commented Oct 22, 2018

@julien, could you take a look at this one?

@jbalsas
Copy link
Contributor

jbalsas commented Oct 22, 2018

@julien, could you take a look at this one?

@julien
Copy link
Contributor

julien commented Oct 22, 2018

Just started reviewing :)

:octocat: Sent from GH.

@julien
Copy link
Contributor

julien commented Oct 22, 2018

@jbalsas yes of course

@julien
Copy link
Contributor

julien commented Oct 22, 2018

@rodrigopaulino @jbalsas I tested the changes and the issue seems fixed.
I'd like to re-run the tests on travis but at the moment I'm not able to do it.
I'll keep you updated soon.

@julien
Copy link
Contributor

julien commented Oct 22, 2018

Pull request submitted to #893.

:octocat: Sent from GH.

@julien julien changed the title Fix #845 - Remove resizer everytime the cursor gets out of the pillar… Fix #845 - Remove resizer everytime the cursor gets out of the pillar… Oct 22, 2018
@julien julien closed this Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants