Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive overhaul of CONTRIBUTING.md #1099

Merged
merged 3 commits into from
Feb 13, 2019
Merged

Massive overhaul of CONTRIBUTING.md #1099

merged 3 commits into from
Feb 13, 2019

Conversation

wincent
Copy link
Contributor

@wincent wincent commented Feb 13, 2019

As discussed here.

Let's remove all the info that doesn't reflect our actual development practices. Namely, we've never managed the "release branches" the way discussed in the document.

I also added top-level descriptions about branch structure and important files and folders.

It is already partially soft-wrapped (on some of the lines). Do this for
consistency with the other Markdown files in the repo, which are all
soft-wrapped.
As discussed here:

#1094 (comment)

Let's remove all the info that doesn't reflect our actual development
practices. Namely, we've never managed the "release branches" the way
discussed in the document.

I also added top-level descriptions about branch structure and important
files and folders.
@julien
Copy link
Contributor

julien commented Feb 13, 2019

Just started reviewing :)

:octocat: Sent from GH.

@julien julien merged commit cd65cd8 into liferay:master Feb 13, 2019
@wincent wincent deleted the contributing-updates/pt-ii branch February 14, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants