Fixes #1048 | Add button to remove images #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next part of the fix is to add a button to update images.
wincent
reviewed
Feb 12, 2019
There was a problem hiding this comment.
Looks good apart from what looks to be an unnecessary prop?
Also, I noticed that we're doing the addComand call in two different ways in the codebase: one like you're doing here and another with new CKEDITOR.command. As a follow-up might be good to switch them all to use the pattern you're using here (assuming they are actually equivalent).
refactor remove image button
wincent
approved these changes
Feb 13, 2019
| * @inheritDoc | ||
| */ | ||
| render() { | ||
| const cssClass = `ae-button ${this.getStateClasses()}`; |
There was a problem hiding this comment.
Looking forward to getting away from this pattern (where we call a method that we don't define on the class instance but inherit magically due to our HOC's use of extends).
wincent
reviewed
Feb 13, 2019
This was referenced Feb 13, 2019
|
Merging this so it doesn't get stale with respect to the parallel changes going on with the language files (eg. #1107). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next part of the fix is to add a button to update
images.