Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8 more lints, including last of the "no-unused-vars" #1032

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fix 8 more lints, including last of the "no-unused-vars" #1032

merged 1 commit into from
Jan 30, 2019

Conversation

wincent
Copy link
Contributor

@wincent wincent commented Jan 29, 2019

Fixes:

src/components/buttons/button-embed-video-edit.jsx
  120:9   error  'icon' is assigned a value but never used              no-unused-vars

src/plugins/dragresize_ie11.js
    95:8   error  'config' is assigned a value but never used                                                                 no-unused-vars
  1045:4   error  The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype  guard-for-in
  1047:10  error  'dimension' is assigned a value but never used                                                              no-unused-vars
  1050:9   error  'dimension' is not defined                                                                                  no-undef
  1050:22  error  'dimension' is not defined                                                                                  no-undef

src/plugins/tableresize.js
  404:7   error  'destroy' is assigned a value but never used  no-unused-vars

src/plugins/tabletools.js
  803:8  error  'lang' is assigned a value but never used  no-unused-vars

The "dragresize_ie11.js" ones are a bit embarrassing, because I actually caused 4 of those in (f9f3850) ie. #1019. This is why we need QA I guess, because somehow our test suite isn't enough to catch mistakes like this.

Test plan: npm run dev && npm run test && npm run start and check
demo.

Related: #990

Fixes:

```
src/components/buttons/button-embed-video-edit.jsx
  120:9   error  'icon' is assigned a value but never used              no-unused-vars

src/plugins/dragresize_ie11.js
    95:8   error  'config' is assigned a value but never used                                                                 no-unused-vars
  1045:4   error  The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype  guard-for-in
  1047:10  error  'dimension' is assigned a value but never used                                                              no-unused-vars
  1050:9   error  'dimension' is not defined                                                                                  no-undef
  1050:22  error  'dimension' is not defined                                                                                  no-undef

src/plugins/tableresize.js
  404:7   error  'destroy' is assigned a value but never used  no-unused-vars

src/plugins/tabletools.js
  803:8  error  'lang' is assigned a value but never used  no-unused-vars
```

The "dragresize_ie11.js" ones are a bit embarrassing, because I actually
caused 4 of those in (f9f3850) ie. #1019. This is why we need
QA I guess, because somehow our test suite isn't enough to catch
mistakes like this.

Test plan: `npm run dev && npm run test && npm run start` and check
demo.

Related: #990
@julien
Copy link
Contributor

julien commented Jan 30, 2019

Just started reviewing :)

:octocat: Sent from GH.

@julien julien merged commit 43342a6 into liferay:2.x-develop Jan 30, 2019
@wincent wincent deleted the lint/n+23 branch January 30, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants