Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring linting up to date #990

Closed
wincent opened this issue Jan 24, 2019 · 1 comment
Closed

Bring linting up to date #990

wincent opened this issue Jan 24, 2019 · 1 comment
Assignees
@wincent
Labels
technical debt

Comments

@wincent
Copy link
Contributor

wincent commented Jan 24, 2019

Get this up to date with our practices from other projects. We're currently not even running lints in an automated fashion, although ESLint is listed a dev dependency.

Internal issue: https://issues.liferay.com/browse/IFI-418
@wincent wincent self-assigned this Jan 24, 2019
julien added a commit that referenced this issue Jan 24, 2019
@julien
Merge pull request #991 from wincent/linting
4ab30b6 
Fixes #990 — Bring linting up to date
julien added a commit that referenced this issue Jan 24, 2019
@julien
Merge pull request #994 from wincent/more-linting-and-formatting
637eee7 
Fixes #990 - Bring linting up to date
This was referenced Jan 28, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Jan 30, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@wincent
Copy link
Contributor Author

wincent commented Feb 3, 2019

Going to close this now. Remaining lints will be fixed when addressing #1010.

@wincent wincent closed this as completed Feb 3, 2019
@wincent wincent mentioned this issue Feb 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wincent wincent

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wincent