-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] gossipsub: an extensible baseline pubsub protocol #521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructs_proto from floodsublib with floosub import and overlay parameters
… script, generate rpc_proto.rs, add constants, add commented out code to lib.rs, add an UNLICENSE.
…impl without any changes to FloodSubUpgrade
…impl without any changes to FloodSubUpgrade
…fixing types, etc.
…nner and FloodSubController
…buf. Rename crate to pubsub as it contains gossipsub and floodsub, but gossipsub-and-floodsub are too verbose, and more extensions to gossipsub such as episub may be added later.
…aft/prune, join/leave and fixing some grammar in strings.
This was referenced Oct 17, 2018
Merged
Floodsub has been upgraded for the new design. |
Still trying to catch up with the changes. Details at https://docs.google.com/spreadsheets/d/1Fv8XqLkMjdBkGPkVWfJulJU-5Qv6TSUR4oD5uKSEHW0/edit#gid=456490482. |
See #767. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outdated, see #767.
There is a spec here. Previously I was implementing episub in #291, however that extends on gossipsub, so it's better to implement gossipsub first. It took a while to really get into development as I was reading through relevant specs, code, learnt Go, tokio, protobuf, and how to best extend on floodsub in terms of code structure e.g. with nested structs, traits and copying and pasting private stuff.
Outdated (comments have changed): for a comparison of rpc_proto.rs and rpc.proto between gossipsub and floodsub, see #428.
Closes #421, this renames the branch name for brevity as prior versions should not need to be revisited.