Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] gossipsub: an extensible baseline pubsub protocol #521

Closed
wants to merge 26 commits into from

Conversation

jamesray1
Copy link
Contributor

@jamesray1 jamesray1 commented Sep 28, 2018

Outdated, see #767.

There is a spec here. Previously I was implementing episub in #291, however that extends on gossipsub, so it's better to implement gossipsub first. It took a while to really get into development as I was reading through relevant specs, code, learnt Go, tokio, protobuf, and how to best extend on floodsub in terms of code structure e.g. with nested structs, traits and copying and pasting private stuff.

Outdated (comments have changed): for a comparison of rpc_proto.rs and rpc.proto between gossipsub and floodsub, see #428.

Closes #421, this renames the branch name for brevity as prior versions should not need to be revisited.

// Importing floodsub isn't sufficient as there is a lot of private stuff.
// For this reason it seems that floodsub and gossipsub need to be in the same
// file. It seems like you need to copy and paste pretty much everything from floodsub,
// as public parts contain private parts. 
// 
// Going forward, the floodsub crate could also be maintained in this crate,
// to avoid duplication of maintaining floodsub in this crate and in the
// floodsub crate.

…ructs_proto from floodsublib with floosub import and overlay parameters
… script, generate

rpc_proto.rs, add constants, add commented out code to lib.rs, add an UNLICENSE.
@jamesray1 jamesray1 changed the title Gossipsub [WIP] Gossipsub Sep 28, 2018
@jamesray1 jamesray1 changed the title [WIP] Gossipsub [WIP] gossipsub: an extensible baseline pubsub protocol Sep 28, 2018
This was referenced Oct 17, 2018
@jamesray1
Copy link
Contributor Author

jamesray1 commented Oct 24, 2018

Due to #568, floodsub will need to be made compatible before continuing work on gossipsub, which extends on floodsub. #573 needs reviewing, then work on floodsub.

@tomaka
Copy link
Member

tomaka commented Nov 15, 2018

Floodsub has been upgraded for the new design.

@jamesray1
Copy link
Contributor Author

Still trying to catch up with the changes. Details at https://docs.google.com/spreadsheets/d/1Fv8XqLkMjdBkGPkVWfJulJU-5Qv6TSUR4oD5uKSEHW0/edit#gid=456490482.

@jamesray1
Copy link
Contributor Author

See #767.

@jamesray1 jamesray1 closed this Dec 11, 2018
@ghost ghost removed the in progress label Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants