[For comparison only] Compare gossipsub with floodsub #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructs_proto from floodsublib with floosub import and overlay parameters
… script, generate rpc_proto.rs, add constants, add commented out code to lib.rs, add an UNLICENSE.
…ssipsub for comparison
|
(you can do this locally with |
|
Yes that did occur to me, however I thought that it may be helpful for reviewers of gossipsub to also compare. |
|
The WIP PR is for that already, isn't it? |
|
I have referred to this PR from #421, which has a separate gossipsub crate to floodsub, so a comparison doesn't show. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to compare the rpc_proto.rs and rpc.proto files for now.