Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delimited read/write in protocol muxer(multiselect) #248

Merged
merged 2 commits into from
Aug 18, 2019
Merged

Add delimited read/write in protocol muxer(multiselect) #248

merged 2 commits into from
Aug 18, 2019

Conversation

mhchia
Copy link
Contributor

@mhchia mhchia commented Aug 15, 2019 •
edited
Loading

mhchia added 2 commits August 16, 2019 11:06
@mhchia
Add delim_encode and delim_read
ee8d5b9 
- Add `StreamCommunicator` and `RawConnectionCommunicator`, read/write
messages with delim codec, with `IMuxedStream` and `IRawConnection`
respectively.
- Use it in `Multiselect` and `MultiselectClient`.
@mhchia
Fix isort
c03b19b
@mhchia mhchia mentioned this pull request Aug 16, 2019
Merged
NIC619
NIC619 approved these changes Aug 18, 2019
View reviewed changes
Copy link
Contributor

@NIC619 NIC619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhchia mhchia merged commit 5d61180 into libp2p:master Aug 18, 2019
@mhchia mhchia deleted the fix/add-delim branch August 18, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NIC619 NIC619 NIC619 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add delimited read/write
2 participants
@mhchia @NIC619