[WIP] Connection and stream interop between Python and Go #175
Conversation
|
Really great to see someone working on this! As this is a crucial functionality that depends on the whole py-libp2p networking stack being able to work with that of go-libp2p, I'm tagging @raulk in case he has any input here. EDIT: See Raul’s response below as he describes the accurate steps to exchanging peer IDs. With regards to your issue (Raul please correct me if I have this wrong or if there is some other place where sending peer IDs over the wire should take place), it could be useful to implement the identify protocol in order to achieve the sharing of peer IDs when a connection is established. |
|
Hey! A few notes: peer IDs are exchanged along with public keys during the crypto handshake (SecIO, TLS 1.3, Noise in the future). Identify is a vital protocol, but by the time it kicks in, you already have a secure and multiplexed connection (and identify operates on a stream). |
TODOs - Find out when we should send `peer_id` - Make `new_stream` work Successfully established MuxedConn But go side crashes after having the connection. My guess is related to the empty PeerID Add `muxed_multistream` Add request_handler for Identify Currently connections and streams work Plus identify Remove binary file `interop`
mhchia
force-pushed
the
fix/interop-with-go
branch
from
faf4364 to
a792c54
Compare
|
Rebased onto master but tests fail. It seems like incoming connections are not handled well. |
|
In this PR, only |
[Sill work in progress]
Fixes #169.
Note
Ensured that we can establish an "insecure" and "multiplexed" connection with several modifications.
PeerIDright after the initiator dials.PeerIDexchange protocol in the insecure security channel: Add draft spec for plaintext key exchange protocol specs#186.Ensured that we can open a stream through the established connection with several modifications.
b'0'when openning a stream.