Feat/update profile #2829
Merged
Feat/update profile #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kyranjamie
force-pushed
the
feat/update-profile
branch
from
0e74ceb to
1c3ae7b
Compare
|
@friedger I've pushed the changes but the prettier, typescript, dependency checker, and unit tests are failing. When working locally, you can check these with |
|
Should this build work okay for QA despite the failed checks? |
kyranjamie
force-pushed
the
feat/update-profile
branch
2 times, most recently
from
8626b6b to
d9c917f
Compare
kyranjamie
requested review from
edu-stx and
fbwoolf
and removed request for
edu-stx
|
LGTM! |
fbwoolf
approved these changes
Dec 9, 2022
edu-stx
approved these changes
Dec 12, 2022
kyranjamie
force-pushed
the
feat/update-profile
branch
2 times, most recently
from
98b69e6 to
f97f7f0
Compare
kyranjamie
force-pushed
the
feat/update-profile
branch
2 times, most recently
from
a641db4 to
73fdb99
Compare
feat: fix import fix: use correct ui components fix: use whenStxChainId, use UI components chore: upgrade stacks.js v5 fix: path url trailing slash fix: revert accidential changes chore: restore test files for profile updates fix: fix resolution of @stacks/profile to 6.0.0 fix: restore event handler in content-script, apply prettier fix: remove waitForNavigation fix: revert wrong rebase changes feat: add support for update-profile request feat: fix import chore: upgrade stacks.js v5 fix: path url trailing slash fix: revert accidential changes chore: restore test files for profile updates fix: restore event handler in content-script, apply prettier fix: remove duplicate imports chore: add @stacks/profile
kyranjamie
force-pushed
the
feat/update-profile
branch
from
73fdb99 to
f3354c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of Friedger's PR with Ci permissions to create build
Todo