Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating the public profile #2544

Closed
friedger opened this issue Jul 7, 2022 · 9 comments · Fixed by #2829
Closed

Support updating the public profile #2544

friedger opened this issue Jul 7, 2022 · 9 comments · Fixed by #2829
Assignees
Labels
enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@friedger
Copy link
Contributor

friedger commented Jul 7, 2022

Users have a public profile (sometimes registered via the zonefile) that contains public information like where users store their data for certain apps. Currently, the profile contains a schema definition for Person. However, there is no way for the user to add or change the personal details.

This feature request is a first step to support updating the public profile. It is limited to properties of the Person schema.

Application can request to update the users profile, then the user has to confirm the change via UI like this:

Screenshot from 2022-07-07 13-19-43

This feature requires:

  • handling a new type of request (update profile) from apps
  • adding UI flow to confirm profile updates
  • re-useing existing functions to upload the updated and signed profile

In connect (see hirosystems/connect#246):

  • adding new type of request (doUpdateProfile)

//cc @markmhx @yknl

@friedger
Copy link
Contributor Author

friedger commented Jul 7, 2022

If approved, I am happy to send a pull request

@aulneau
Copy link
Contributor

aulneau commented Jul 7, 2022

I'm happy to help out here too

@Hero-Gamer
Copy link

I LIKE THIS FEATURE!

@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p2 Critical functionality needed by few users, with no clear alternatives labels Jul 8, 2022
@markmhendrickson
Copy link
Collaborator

This generally approach looks great to me. We'd love to review a PR with this addition.

@kyranjamie
Copy link
Collaborator

Rather than a specific profile updater feature, could this be implemented as a more generic gaia data updater?

@friedger
Copy link
Contributor Author

friedger commented Jul 9, 2022

@kyranjamie The underlying logic could handle that. The app should then send mime-type, filename and file content, optional encryption key.

This issue is about limited editing feature of the profile because the public profile contains app data that users might not want to mess with in general. Therefore, the flow for this issue would accept only

mime-type = application/json
filename = profile.json
encryption key = undefined
file content follows strictly Person schema

@aulneau
Copy link
Contributor

aulneau commented Jul 9, 2022

While I think it makes sense to potentially have a Gaia generic function, the profile related stuff does warrant its own methods in my opinion. The profile is a core element of stacks auth and wallet usage, and we should start giving it more focus.

I vote for a specific profile related function before a generic Gaia method.

@friedger
Copy link
Contributor Author

@markmhendrickson
Copy link
Collaborator

@kyranjamie is going to prepare for release

@fbwoolf fbwoolf moved this from Review to Ready to release in Hiro Wallet (DEPRECATED) Dec 16, 2022
@markmhendrickson markmhendrickson moved this from Ready to release to Released in Hiro Wallet (DEPRECATED) Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants