-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signStructuredData not in line with SIP018 specification #2460
Milestone
Comments
FYI: stacksgov/sips#57 (comment) The structured data prefix has been changed to make sure that SIP018 messages can absolutely never be valid transactions. |
This was referenced Jun 2, 2022
blockstack-devops
pushed a commit
that referenced
this issue
Jun 23, 2022
blockstack-devops
pushed a commit
that referenced
this issue
Jun 29, 2022
# [3.11.0-beta.1](v3.10.0...v3.11.0-beta.1) (2022-06-29) ### Bug Fixes * add referer headers to api calls ([4b23da1](4b23da1)) * bad ui copy practices ([828082a](828082a)) * current account name ([7b54aa4](7b54aa4)) * direct landing on send form page, closes [#2470](#2470) ([b98d570](b98d570)) * firefox white screen with referer header ([427e592](427e592)) * fund page layout shift ([9f66227](9f66227)) * header version alignment ([676b5dd](676b5dd)) * new tab send form nonce and scroll ([62e6d11](62e6d11)) * nonce with pending tx ([9ba8234](9ba8234)) * onboarding state ([40bb84b](40bb84b)) * receive page scroll ([fd363de](fd363de)) * remove double scrollbars, emotion set up ([fc0be70](fc0be70)) * send form white screen ([1ff0e70](1ff0e70)) * sign message oncancel ([f2d75f8](f2d75f8)) * sign message with line breaks ([fdc8866](fdc8866)) * suggested steps only updating with refresh ([2dea9c6](2dea9c6)) * support SIP-018 for structured data signing ([8087cd6](8087cd6)), closes [#2443](#2443) [#2460](#2460) [#2419](#2419) * use the anchor mode from the input transaction ([92c7c6a](92c7c6a)) ### Features * add image to fungible token ([c891983](c891983)), closes [#1800](#1800) * initial support jwt signing on ledger ([5f4696e](5f4696e)) * support Ledger hardware wallets ([8a7d0d2](8a7d0d2))
blockstack-devops
pushed a commit
that referenced
this issue
Jun 30, 2022
# [3.11.0](v3.10.0...v3.11.0) (2022-06-30) ### Bug Fixes * add referer headers to api calls ([4b23da1](4b23da1)) * bad ui copy practices ([828082a](828082a)) * current account name ([7b54aa4](7b54aa4)) * direct landing on send form page, closes [#2470](#2470) ([b98d570](b98d570)) * firefox white screen with referer header ([427e592](427e592)) * fund page layout shift ([9f66227](9f66227)) * header version alignment ([676b5dd](676b5dd)) * loading first steps ([bbbff9c](bbbff9c)) * new tab send form nonce and scroll ([62e6d11](62e6d11)) * nonce with pending tx ([9ba8234](9ba8234)) * onboarding state ([40bb84b](40bb84b)) * receive page scroll ([fd363de](fd363de)) * remove double scrollbars, emotion set up ([fc0be70](fc0be70)) * send form white screen ([1ff0e70](1ff0e70)) * sign message oncancel ([f2d75f8](f2d75f8)) * sign message with line breaks ([fdc8866](fdc8866)) * suggested steps only updating with refresh ([2dea9c6](2dea9c6)) * support SIP-018 for structured data signing ([8087cd6](8087cd6)), closes [#2443](#2443) [#2460](#2460) [#2419](#2419) * use the anchor mode from the input transaction ([92c7c6a](92c7c6a)) ### Features * add image to fungible token ([c891983](c891983)), closes [#1800](#1800) * initial support jwt signing on ledger ([5f4696e](5f4696e)) * support Ledger hardware wallets ([8a7d0d2](8a7d0d2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See hirosystems/connect#225 (comment)
As part of this task, we need to make sure that all the signatures used during the signing flow are in RSV format.
References
stacksgov/sips#57
hirosystems/stacks.js#1269
hirosystems/connect#225
The text was updated successfully, but these errors were encountered: