Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sip018 tests #1281

Closed
janniks opened this issue Jun 1, 2022 · 2 comments
Closed

add sip018 tests #1281

janniks opened this issue Jun 1, 2022 · 2 comments
Assignees
@beguene

Comments

@janniks
Copy link
Collaborator

janniks commented Jun 1, 2022

add tests with test vectors from sip018 https://github.com/MarvinJanssen/sips/blob/feat/signed-structured-data/sips/sip-018/sip-018-signed-structured-data.md
@janniks janniks added the test label Jun 1, 2022
@janniks janniks self-assigned this Jun 1, 2022
@beguene
Copy link
Contributor

beguene commented Jun 2, 2022

@janniks FYI I am working on updating our wallet with SIP018 leather-io/extension#2460. As part of this I am currently adding some methods to stacks.js to handle encoding/decoding + signingStructuredData functions to stacks.js
I will put up a PR soon I can also add those tests vectors if you did not work on it yet.

@janniks janniks assigned beguene and unassigned janniks Jun 2, 2022
@janniks
Copy link
Collaborator Author

janniks commented Jun 2, 2022

perfect, thanks 🙏

beguene added a commit to beguene/stacks.js that referenced this issue Jun 2, 2022
@beguene
feat: add SIP-018 support
1786b9f 
closes hirosystems#1283 hirosystems#1281
@beguene beguene mentioned this issue Jun 2, 2022
Merged
4 tasks
beguene added a commit to beguene/stacks.js that referenced this issue Jun 3, 2022
@beguene
feat: add SIP-018 support
1e87cc5 
closes hirosystems#1283 hirosystems#1281
beguene added a commit to beguene/stacks.js that referenced this issue Jun 3, 2022
@beguene
feat: add SIP-018 support
1425a8e 
closes hirosystems#1283 hirosystems#1281
janniks pushed a commit that referenced this issue Jun 7, 2022
@beguene @janniks
feat: add SIP-018 support
a4c0577 
closes #1283 #1281
@janniks janniks closed this as completed Jun 7, 2022
@github-actions github-actions bot mentioned this issue Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beguene beguene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beguene @janniks