Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifies pre-commit hook python version to 3.10 #9810

Merged

Conversation

akolson
Copy link
Member

@akolson akolson commented Nov 3, 2022

Summary

This PR pins the pre-commit python container version to 3.10 as a result of a linting build failures

References

Bug is experienced here #9809

Reviewer guidance

Linting should build successfully on Github


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson requested a review from rtibbles November 3, 2022 19:36
@akolson akolson added the TODO: needs review Waiting for review label Nov 3, 2022
@akolson akolson added this to the Planned Patch 7 milestone Nov 3, 2022
@akolson akolson requested a review from bjester November 3, 2022 19:39
@akolson akolson marked this pull request as ready for review November 3, 2022 19:39
@akolson akolson changed the title Specifies pre-commit hoot python version to 3.10 Specifies pre-commit hook python version to 3.10 Nov 3, 2022
@akolson akolson mentioned this pull request Nov 4, 2022
9 tasks
@rtibbles rtibbles merged commit 36b146e into learningequality:release-v0.15.x Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants