-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests text wrapping in KRadioButton #9802
Tests text wrapping in KRadioButton #9802
Conversation
08082bf
to
b1f757c
Compare
This PR is ready for merging once review process is complete as learningequality/kolibri-design-system#380 has been merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go once the KDS version business is updated as it looks like your KDS PR was merged.
Yes @nucleogenesis this is the case., the KDS PR has been merged. An approval would now allow the merge. Thanks |
Manual QA passes as well - good to go! @radinamatic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent news from QA, thank you @akolson for fixing this! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
This PR tests that the

KRadioButton
labels wrap text and not truncate textBefore
After:

Please note that my KDS fork has been referenced for testing purposes. This will be reverted once KDS PR learningequality/kolibri-design-system#380 gets merged
References
learningequality/kolibri-design-system#380
Reviewer guidance
http://localhost:8000/en/device/#/settings
or any other page where theKRadioButton
is used.KRadioButton
labels are wrapping and not truncating textNote: This pr build has a known lint failure that is resolved by Specifies pre-commit hook python version to 3.10 #9810
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)