Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests text wrapping in KRadioButton #9802

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

akolson
Copy link
Member

@akolson akolson commented Oct 26, 2022

Summary

This PR tests that the KRadioButton labels wrap text and not truncate text
Before
Screenshot 2022-10-26 at 22 31 19

After:
Screenshot 2022-10-26 at 22 29 31

Please note that my KDS fork has been referenced for testing purposes. This will be reverted once KDS PR learningequality/kolibri-design-system#380 gets merged

References

learningequality/kolibri-design-system#380

Reviewer guidance

  • Navigate to http://localhost:8000/en/device/#/settings or any other page where the KRadioButton is used.
  • Resize the window to verify that the KRadioButton labels are wrapping and not truncating text
    Note: This pr build has a known lint failure that is resolved by Specifies pre-commit hook python version to 3.10 #9810

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson added the TODO: needs review Waiting for review label Oct 26, 2022
@akolson akolson modified the milestones: Planned Patch 7, 0.16.0 Oct 27, 2022
@akolson akolson marked this pull request as ready for review October 27, 2022 12:41
@akolson akolson force-pushed the test-wrap-kradiobutton branch from 08082bf to b1f757c Compare November 4, 2022 08:37
@akolson
Copy link
Member Author

akolson commented Nov 4, 2022

This PR is ready for merging once review process is complete as learningequality/kolibri-design-system#380 has been merged

@akolson akolson changed the title [DO NOT MERGE] Tests text wrapping in KRadioButton Tests text wrapping in KRadioButton Nov 4, 2022
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go once the KDS version business is updated as it looks like your KDS PR was merged.

@akolson
Copy link
Member Author

akolson commented Nov 9, 2022

Yes @nucleogenesis this is the case., the KDS PR has been merged. An approval would now allow the merge. Thanks

@pcenov
Copy link
Member

pcenov commented Nov 17, 2022

Manual QA passes as well - good to go! @radinamatic

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent news from QA, thank you @akolson for fixing this! 💯 :shipit:

@nucleogenesis nucleogenesis self-requested a review November 22, 2022 00:17
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akolson akolson merged commit f02ed81 into learningequality:develop Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants