Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handleConfirmDelete issues in SectionEditor #12536

Merged

Conversation

nucleogenesis
Copy link
Member

Summary

Cherry-picks the commit that fixes a regression in section deletion.

An error remained for me re: 'avoiding redundant navigation' but saw no UX issues due to this.

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Aug 5, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, I will let manual QA have the final word here!

@radinamatic
Copy link
Member

All possible quiz sections changes (renaming, reordering, moving questions around, adding more, etc.) combined with the section deletion, were performed and completed without UI errors.

Uncaught (in promise) NavigationDuplicated: Avoided redundant navigation to current location error did appear in the console, but with no apparent user-facing consequences.

2024-08-05_20-50-43

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏🏽 💯 :shipit:

@rtibbles
Copy link
Member

rtibbles commented Aug 5, 2024

Had a quick conversation with @nucleogenesis about the possible provenance of the problematic navigation, and it seems like it's not hiding anything further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EQM - Add new section/Edit Section - The 'Section settings' modal remains open after clicking 'Delete section'
3 participants