Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQM - Add new section/Edit Section - The 'Section settings' modal remains open after clicking 'Delete section' #12532

Closed
pcenov opened this issue Aug 2, 2024 · 3 comments · Fixed by #12536
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression

Comments

@pcenov
Copy link
Member

pcenov commented Aug 2, 2024

Observed behavior

When adding a new section or editing it if I click the 'Delete section' button, then the 'Section settings' remains open and cannot be closed by the user so that the user is forced to reload the page resulting in loss of any unsaved changes.

Video:

Delete.section.mp4

Expected behavior

The 'Section settings' modal should disappear.

Steps to reproduce the issue

  1. Install the build from https://github.com/learningequality/kolibri/releases/tag/v0.17.0-rc2
  2. Create a new quiz.
  3. Click the 'Add section' button and then click the 'Delete section' button.
  4. Alternatively after having already added a section click the 'Options' button, select 'Edit section' and click 'Delete section'.

Usage Details

Ubuntu 22 - Chrome
Windows 11 - Edge

@pcenov
Copy link
Member Author

pcenov commented Aug 2, 2024

@radinamatic

@radinamatic radinamatic added bug Behavior is wrong or broken APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Aug 2, 2024
@radinamatic
Copy link
Member

This is the same error I encountered in #12462 (comment), which we decided to postpone to patch 1 to do a more thorough testing. Can we cherry-pick the fix you implemented there, @nucleogenesis? Thank you!

@radinamatic radinamatic added the P0 - critical Priority: Release blocker or regression label Aug 2, 2024
@radinamatic radinamatic linked a pull request Aug 6, 2024 that will close this issue
@radinamatic
Copy link
Member

Fixed in #12536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants