Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropup icon added #605

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Dropup icon added #605

merged 9 commits into from
Apr 2, 2024

Conversation

satyamkale27
Copy link
Contributor

Description

dropup icon added

Issue addressed

<#594>

Addresses #PR# HERE

Before/after screenshots

Before
before

After
after

Changelog

  • [#PR no]
    • Description: added a new svg icon dropup-icon

[#PR no]: PR link

Steps to test

  1. Step 1 run the project yarn dev
  2. Step 2 go to http://localhost:4000/icons#token-dropup
  3. ...

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • [] Critical and brittle code paths are covered by unit tests
  • [] The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

@satyamkale27
Copy link
Contributor Author

@MisRob take a look

@MisRob MisRob requested a review from AllanOXDi April 1, 2024 05:01
@MisRob MisRob added the TODO: needs review Waiting for review label Apr 1, 2024
@MisRob MisRob changed the base branch from release-v4 to release-v3 April 2, 2024 13:03
@MisRob MisRob changed the base branch from release-v3 to release-v4 April 2, 2024 13:03
@MisRob MisRob changed the base branch from release-v4 to release-v3 April 2, 2024 13:07
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @satyamkale27, it looks good overall.

I pushed some changes related to rebasing to the release-v3 branch. It's related to our release organization and nothing to be worried about.

I also updated CHANGELOG.md. If you'd like to keep contributing to the KDS, you could look at the CHANGELOG.MD changes I pushed and use the same approach in your next PRs.

@MisRob MisRob merged commit b8ebdae into learningequality:release-v3 Apr 2, 2024
8 checks passed
@MisRob MisRob self-assigned this Apr 2, 2024
@satyamkale27 satyamkale27 deleted the dropup-icon branch April 6, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants