Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upward icon opposite dropdown #594

Closed
bjester opened this issue Mar 28, 2024 · 9 comments
Closed

Add upward icon opposite dropdown #594

bjester opened this issue Mar 28, 2024 · 9 comments
Assignees
Labels
category: library Shared code library Component: KIcon good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome product: Studio Relevant to a specific issue in Studio

Comments

@bjester
Copy link
Member

bjester commented Mar 28, 2024

Product

Studio

Desired behavior

Add the upward version of dropdown as dropup or upward or some other name. Also, since this icon is fairly generic, it may make sense to also add the left and right icons for comprehensivity.

Current behavior

No such icon exists, and the chevron icons produce a completely different feel.

(Optional) The Value Add

Studio uses it in opposing contexts of the existing dropdown icon.

(Optional) Possible Tradeoffs

An alternative approach could be to simply use CSS to rotate the icon, but it would help to have that integrated into KIcon if the case. Although, there may be accessibility concerns in using CSS rotations on it.

@bjester bjester added category: library Shared code library product: Studio Relevant to a specific issue in Studio Component: KIcon good first issue Self-contained, straightforward, low-complexity labels Mar 28, 2024
@MisRob MisRob added the help wanted Open source contributors welcome label Mar 29, 2024
@MisRob
Copy link
Member

MisRob commented Mar 29, 2024

@satyamkale27
Copy link
Contributor

satyamkale27 commented Mar 29, 2024

@MisRob I want to work on this issue please assign it to me.

@MisRob
Copy link
Member

MisRob commented Mar 29, 2024

Hello @satyamkale27, thank you. I need to get the icon file from our design team at first. I will assign you as soon as I upload the file here.

@bjester
Copy link
Member Author

bjester commented Mar 29, 2024

@satyamkale27
Copy link
Contributor

@MisRob should i start working on it.

@MisRob
Copy link
Member

MisRob commented Mar 29, 2024

I will assign you, @satyamkale27

@satyamkale27
Copy link
Contributor

@MisRob i am begineer in vue js i am learning while contributing please will you guide me in this
(An alternative approach could be to simply use CSS to rotate the icon, but it would help to have that integrated into KIcon if the case. Although, there may be accessibility concerns in using CSS rotations on it.)

@MisRob
Copy link
Member

MisRob commented Apr 1, 2024

Thank you, @satyamkale27, we will have a look

@MisRob
Copy link
Member

MisRob commented Apr 3, 2024

Closed by #605

@MisRob MisRob closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: library Shared code library Component: KIcon good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome product: Studio Relevant to a specific issue in Studio
Projects
None yet
Development

No branches or pull requests

3 participants