Availability

[rtibbles]

Summary

Properly stamps availability flags, files_complete etc. on different languages, and ensures that the subtitle fallback annotation works properly.

Also filters retrieval of youtube_ids for downloading and deletion by whether there are any files to download/delete.

Finally, prevents overwriting/download of videos that already exist in the content dir.

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

• Have tests been written for the new code? If you're fixing a bug, write a regression test (or have a really good reason for not writing one... and I mean really good!)
• Has documentation been written/updated?
• New dependencies (if any) added to requirements file
• Add an entry to CHANGELOG.rst

Issues addressed

Fixes #4994, fixes #4990, and supersedes #5016.

[rtibbles]

Genuine test failure. Fixing.

[rtibbles]

Issue here was that we were updating every Video node on annotation, not just those that needed. As @jamalex has previously noted, this can take 45 minutes for every video node.

[MCGallaspy]

killall --wait sc this command timed out... odd, but otherwise the build passes.

[rtibbles]

Also this:

======================================================================
FAIL: test_delete_existing_video_file (kalite.updates.tests.api_tests.TestAdminApiCalls)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/ka-lite/kalite/updates/tests/api_tests.py", line 77, in test_delete_existing_video_file
    self.assertFalse(os.path.exists(self.fake_video_file), "Video file should not exist on disk.")
AssertionError: True is not false : Video file should not exist on disk.

----------------------------------------------------------------------

Can't replicate locally.

[rtibbles]

@MCGallaspy Tests pass!