Only download videos not already downloaded #5016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,10 +130,12 @@ def start_video_download(request): | |||
| lang = json.loads(request.body or "{}").get("lang", "en") | |||
|
|
|||
| youtube_ids = get_download_youtube_ids(paths, language=lang) | |||
|
|
|||
| ids_to_queue = {id_: title for (id_, title) in youtube_ids.iteritems() | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Allows the UpdateProgressLog for video downloads/deletes to be accurately reported, as well as avoiding unnecessary downloads.
MCGallaspy
force-pushed
the
4990-video-count-mismatch
branch
from
6489044 to
880e885
Compare
|
@rtibbles in the interest of time, I'm compromising my test policy. |
|
I still don't think checking the file system is the right fix. We should, perhaps, check that at download, but the point of flagging these things in the database is so that we don't have to constantly check the file system. I have implemented a fix for this in my fix for the download availability issue for different languages, so will close this when that is opened. |
|
Closing in preference to #5045. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Filters the requested ids to download. I think this could potentially increase the runtime of this endpoint significantly, since each youtube_id hits the database -- but maybe it could be improved by a big constant factor if all the content items are fetched at once? Alternatively, if the requests are batched on the front-end. Thoughts?
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Have tests been written for the new code? If you're fixing a bug, write a regression test (or have a really good reason for not writing one... and I mean really good!)Issues addressed
Fixes #4990.