Rating display issues #4750
Merged
Rating display issues #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Played around with different layouts within bootstrap, not totally satisfying for resolutions > ~400px and < 768 px, but good enough without changing the hb template or view logic. At smallest res, all rating buttons and labels stack, and no hover-label is shown. As the resolution increases (to bootstrap's col-sm- size), the labels and buttons flatten out, and a hover label is shown. The size of the buttons also progressively increases.
|
@radinamatic tagging you, since you opened one of the issues. |
|
@rtibbles according to Trello board you're assigned to ratings stuff. |
|
We could catch a But why doesn't Selenium raise a |
|
This looks like a decent fix. Tests pass. Merging. |
This was referenced Feb 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4308, fixes #4544.
See screenshots. Commit msg:
Smallest
Larger
Largest
