Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content rating responsive design issues #4544

Closed
radinamatic opened this issue Sep 30, 2015 · 1 comment
Closed

Content rating responsive design issues #4544

radinamatic opened this issue Sep 30, 2015 · 1 comment
Assignees
@MCGallaspy
Labels
beginner ux / frontend
Milestone
0.16.0

Comments

@radinamatic
Copy link
Member

Content rating responsive design issues

Branch: 0.15, ka-lite_0.15~b2-0ubuntu1_all.deb installer on Ubuntu 15.04

Issue on both WXP & Ubuntu, FF & Chrom(ium)

Current Behavior:
On browser's window at >1200px, all's well:

responsive-cr

On <1200px, one star slides below:

responsive-cr2

Going further, star returns to its place, but strings Poor/High appear above and below:

responsive-cr3

This is specially confusing while hovering over stars:

responsive-cr4
@MCGallaspy MCGallaspy self-assigned this Sep 30, 2015
@MCGallaspy MCGallaspy added this to the 0.16.0 milestone Oct 26, 2015
MCGallaspy added a commit to MCGallaspy/ka-lite that referenced this issue Dec 10, 2015
@MCGallaspy
Address rating responsive issues; fixes learningequality#4544
faa5b6e 
Played around with different layouts within bootstrap,
not totally satisfying for resolutions > ~400px and < 768 px,
but good enough without changing the hb template or view logic.

At smallest res, all rating buttons and labels stack,
and no hover-label is shown.

As the resolution increases (to bootstrap's col-sm- size),
the labels and buttons flatten out, and a hover label is
shown. The size of the buttons also progressively increases.
@MCGallaspy MCGallaspy mentioned this issue Dec 10, 2015
Merged
@rtibbles
Copy link
Member

rtibbles commented Feb 2, 2016

Fixed in #4750

@rtibbles rtibbles closed this as completed Feb 2, 2016
@rtibbles rtibbles removed the has PR label Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MCGallaspy MCGallaspy

Labels
beginner ux / frontend
Projects
None yet
Milestone
0.16.0
Development

No branches or pull requests
3 participants
@radinamatic @rtibbles @MCGallaspy