Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use free_sized in mpz.cpp #6825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: use free_sized in mpz.cpp #6825

wants to merge 1 commit into from
+1 −1

Conversation

eric-wieser
Copy link
Contributor

The performance win here is pretty negligible (and of course irrelevant with the small allocator enabled), but this is consistent with it being used elsewhere.

Follow-up to #6598

@eric-wieser
perf: use free_sized in mpz.cpp
df9a2ac 
The performance win here is pretty negligible (and of course irrelevant with the small allocator enabled), but this is consistent with it being used elsewhere.
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 28, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 26bc8c5b2a75b316c6a4c5ec52281e1dfd6bd0ac --onto 20c616503abe5ce4253c56dbcd7766a91c675ba0. (2025-01-28 18:33:43)

@eric-wieser eric-wieser mentioned this pull request Jan 29, 2025
Merged
@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Feb 4, 2025
@Kha Kha enabled auto-merge February 4, 2025 12:47
github-merge-queue bot pushed a commit that referenced this pull request Feb 4, 2025
@eric-wieser
chore: re-land "perf: use C23's free_sized when available" (#6844)
0d7e126 
Unreverts #6598

I'll combine #6825 into this before merging.
@Kha
Copy link
Member

Kha commented Feb 11, 2025

@eric-wieser Windows is still not your friend :)

luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 24, 2025
@eric-wieser @luisacicolini
chore: re-land "perf: use C23's free_sized when available" (leanpro…
acde022 
…ver#6844)

Unreverts leanprover#6598

I'll combine leanprover#6825 into this before merging.
@Kha Kha added the awaiting-author Waiting for PR author to address issues label Feb 25, 2025
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 25, 2025
@eric-wieser @luisacicolini
chore: re-land "perf: use C23's free_sized when available" (leanpro…
5b44298 
…ver#6844)

Unreverts leanprover#6598

I'll combine leanprover#6825 into this before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kha Kha Kha approved these changes

Assignees
No one assigned
Labels
awaiting-author Waiting for PR author to address issues release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-wieser @leanprover-community-bot @Kha