perf: use C23's free_sized when available
#6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
free_sized
branch
from
38cb62a to
96ee3bf
Compare
This only has an effect on systems with a default allocator where `free_sized` is faster than `free`. See https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2699.htm for an explanation of this feature. Co-authored-by: Eric Wieser <[email protected]>
eric-wieser
force-pushed
the
free_sized
branch
from
96ee3bf to
80cba6a
Compare
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
|
@eric-wieser Are you not using the small allocator? |
|
Our hope was that https://github.com/google/tcmalloc might be just as good for our use case, but this would only be the case if tcmalloc actually gets access to the same size information that the small allocator has (through |
|
@eric-wieser Thanks for the explanation. I assume you tested it successfully with a compiler supporting it :) ? |
|
@Kha: yes, I tested this patch applied to lean v4.14.0 and it happy builds mathlib. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
Reverts #6598, which broke Windows CI
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 24, 2025
See https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2699.htm for an explanation of this feature. --------- Co-authored-by: Chris Kennelly <[email protected]>
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 24, 2025
…er#6841) Reverts leanprover#6598, which broke Windows CI
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 24, 2025
…ver#6844) Unreverts leanprover#6598 I'll combine leanprover#6825 into this before merging.
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 25, 2025
See https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2699.htm for an explanation of this feature. --------- Co-authored-by: Chris Kennelly <[email protected]>
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 25, 2025
…er#6841) Reverts leanprover#6598, which broke Windows CI
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 25, 2025
…ver#6844) Unreverts leanprover#6598 I'll combine leanprover#6825 into this before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2699.htm for an explanation of this feature.