Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use in Fin.ne_of_val_ne #5011

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Parcly-Taxel
Copy link
Contributor

@Parcly-Taxel Parcly-Taxel commented Aug 13, 2024

Instead of a Not (Eq …) term use the proper in Fin.ne_of_val_ne, to make it symmetric with Fin.val_ne_of_ne, and move the former to the same place as the latter.

This answers a query of @eric-wieser at
leanprover-community/mathlib4#15762 (comment)

Instead of a `Not (Eq …)` term use the proper `≠` in
`Fin.ne_of_val_ne`, to make it symmetric with `Fin.val_ne_of_ne`, and
move the former to the same place as the latter.

This answers a query of @eric-weiser at
leanprover-community/mathlib4#15762 (comment)
@Parcly-Taxel Parcly-Taxel requested a review from kim-em as a code owner August 13, 2024 11:06
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 13, 2024
@kim-em kim-em added this pull request to the merge queue Aug 14, 2024
Merged via the queue into leanprover:master with commit ac2dabd Aug 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants